all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH-SERIES v2 manager/guest-common] replication: improve removal of stale snapshots/volumes
Date: Wed, 27 Jul 2022 13:22:23 +0200	[thread overview]
Message-ID: <ba299e48-3250-a948-c6d7-6e1a01e1087e@proxmox.com> (raw)
In-Reply-To: <20220613102959.36556-1-f.ebner@proxmox.com>

Am 13.06.22 um 12:29 schrieb Fabian Ebner:
> In certain scenarios, see manager 2/2 and guest-common 3/4, replicated
> volumes could end up orphaned. This series attempts to fix those, as
> well as making removal of stale replication snaphsots a bit more
> robust. Also includes some slight documentation improvements regarding
> prepare().
> 

Ping

> v1 can be found here (but there was no discussion):
> https://lists.proxmox.com/pipermail/pve-devel/2020-October/045388.html
> 
> Changes from v1:
>     * Adapt to changed behavior of prepare(), so we still only catch
>       volumes that had replication snapshots belonging to the job.
>     * Drop simplification that would only rely on replication state
>       to get storages for full removal.
>     * Add safe-guard to only remove other replication snaphsots if the
>       last_sync snapshot is present.
> 
> 




  parent reply	other threads:[~2022-07-27 11:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-13 10:29 Fabian Ebner
2022-06-13 10:29 ` [pve-devel] [PATCH v2 manager 1/2] pvesr: rename last_snapshots to local_snapshots Fabian Ebner
2022-06-13 10:29 ` [pve-devel] [PATCH v2 manager 2/2] pvesr: prepare local job: remove stale replicated volumes immediately Fabian Ebner
2022-06-13 10:29 ` [pve-devel] [PATCH v2 guest-common 1/4] replication: prepare: adapt/expand function comment Fabian Ebner
2022-06-13 10:29 ` [pve-devel] [PATCH v2 guest-common 2/4] replication: rename last_snapshots to local_snapshots Fabian Ebner
2022-06-13 10:29 ` [pve-devel] [PATCH v2 guest-common 3/4] replication: also consider storages from replication state upon removal Fabian Ebner
2022-06-13 10:29 ` [pve-devel] [RFC v2 guest-common 4/4] replication: prepare: safeguard against removal if expected snapshot is missing Fabian Ebner
2022-07-27 11:22 ` Fiona Ebner [this message]
2022-08-02  9:08   ` [pve-devel] applied-series: [PATCH-SERIES v2 manager/guest-common] replication: improve removal of stale snapshots/volumes Fabian Grünbichler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ba299e48-3250-a948-c6d7-6e1a01e1087e@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal