all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: Daniel Kral <d.kral@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [PATCH container 3/3] setup: make the architecture fall back to amd64 for empty strings
Date: Fri, 6 Feb 2026 13:31:39 +0100	[thread overview]
Message-ID: <b9ec785f-d982-4792-b3f7-8caefdf4845a@proxmox.com> (raw)
In-Reply-To: <DG7VBDP4TUI4.35L5K8W125HTS@proxmox.com>

Am 06.02.26 um 1:11 PM schrieb Daniel Kral:
> On Fri Feb 6, 2026 at 11:24 AM CET, Fiona Ebner wrote:
>> Am 04.02.26 um 10:17 AM schrieb Daniel Kral:
>>> Otherwise, if the underlying detect_architecture(...) method returns any
>>> false value, the return value of the call to protected_call(...) will
>>
>> Do you mean undef value here? If I return 0 inside a protected call I get 0
>>
>>> return an empty string.
>>
>> not an empty string.
>>
>> There seems to be a difference in behavior between being in a nested
>> protected call, which will return the result from the $sub directly, and
>> a non-nested protected call, which reads the result from the pipe, which
>> also results in an empty string when the result from $sub is undef.
> 
> Good catch, thanks! I only tried it with non-nested protected calls
> which use the output from the pipe and also assumed that the empty
> string comes from the conversion from a falsy value to a string in perl,
> which is the empty string.

Nit: should probably read "from a falsy value that does convert to an
empty string in Perl". Not all falsy values do ;)




      reply	other threads:[~2026-02-06 12:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-04  9:17 [PATCH-SERIES container 0/3] add missing no-op methods for unmanaged CTs Daniel Kral
2026-02-04  9:17 ` [PATCH container 1/3] setup: add no-op check_systemd_nesting " Daniel Kral
2026-02-04  9:35   ` Daniel Kral
2026-02-05 10:12   ` Robert Obkircher
2026-02-05 10:46     ` Daniel Kral
2026-02-04  9:17 ` [PATCH container 2/3] setup: add no-op detect_architecture " Daniel Kral
2026-02-04  9:17 ` [PATCH container 3/3] setup: make the architecture fall back to amd64 for empty strings Daniel Kral
2026-02-06 10:24   ` Fiona Ebner
2026-02-06 12:12     ` Daniel Kral
2026-02-06 12:31       ` Fiona Ebner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b9ec785f-d982-4792-b3f7-8caefdf4845a@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=d.kral@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal