Re: [pve-devel] [PATCH v6 qemu-server 01/10] add memory parser

[Fiona Ebner <f.ebner@proxmox.com>]

Am 19.06.23 um 09:28 schrieb Alexandre Derumier:
> Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
> ---

There's a new usage for get_dervied_property() since this patch was
sent. Please add it to the next version:

> diff --git a/PVE/QemuConfig.pm b/PVE/QemuConfig.pm
> index d4230895..0e4b1eb8 100644
> --- a/PVE/QemuConfig.pm
> +++ b/PVE/QemuConfig.pm
> @@ -549,8 +549,8 @@ sub get_derived_property {
>         my $cpus =
>             ($conf->{sockets} || $defaults->{sockets}) * ($conf->{cores} || $defaults->{cores});
>         return $conf->{vcpus} || $cpus;
> -    } elsif ($name eq 'max-memory') {
> -       return ($conf->{memory} || $defaults->{memory}) * 1024 * 1024;
> +    } elsif ($name eq 'max-memory') { # current usage maximum, not maximum hotpluggable
> +       return (get_current_memory($conf->{memory}) || $defaults->{memory}) * 1024 * 1024;
>      } else {
>         die "unknown derived property - $name\n";
>      }
>