all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: "Hannes Dürr" <h.duerr@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Stoiko Ivanov <s.ivanov@proxmox.com>,
	Stefan Hanreich <s.hanreich@proxmox.com>
Subject: Re: [pve-devel] [PATCH pve-docs v2 4/4] sdn: add documentation for isolated ports option
Date: Tue, 19 Nov 2024 11:06:12 +0100	[thread overview]
Message-ID: <b8048705-0e89-4480-9249-b100540a1e26@proxmox.com> (raw)
In-Reply-To: <20241118195217.7ae60257@rosa.proxmox.com>

I like your changes, but I would adapt the description more to the 
bridge manpage [0].

[0] https://www.man7.org/linux/man-pages/man8/bridge.8.html

On 11/18/24 19:52, Stoiko Ivanov wrote:
> On Tue, 12 Nov 2024 16:54:25 +0100
> Stefan Hanreich <s.hanreich@proxmox.com> wrote:
>
>> Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
>> ---
>>   pvesdn.adoc | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/pvesdn.adoc b/pvesdn.adoc
>> index 39de80f..b1f2578 100644
>> --- a/pvesdn.adoc
>> +++ b/pvesdn.adoc
>> @@ -383,6 +383,11 @@ Tag:: The unique VLAN or VXLAN ID
>>   VLAN Aware:: Enables vlan-aware option on the interface, enabling configuration
>>     in the guest.
>>   
>> +Isolate Ports:: Sets the isolated flag for all members of this port, except for
>> +the bridge port. This means that every port can only send traffic to the bridge
>> +port. In order for this setting to take effect, you need to restart the VMs
>> +that have interfaces on the VNet.
>> +
> Reading through the VNet docs - I'd rename bridge port to 'interface' and
> members to guest ports. - maybe like this:
> ```
> Isolate Ports:: Sets the isolated flag for all guest ports of this interface,
> but not for the interface itself. This means that guests cannot send traffic to
> each other. In order for this setting to take effect, you need to restart the
> affected guest.
> ```
This means that guests cannot send traffic to each other -> This means 
guests can only send traffic to non-isolated guests

>
>
>>   
>>   [[pvesdn_config_subnet]]
>>   Subnets
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  reply	other threads:[~2024-11-19 10:06 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-12 15:54 [pve-devel] [PATCH pve-common v2 1/4] tap_plug: add support for bridge port isolation Stefan Hanreich
2024-11-12 15:54 ` [pve-devel] [PATCH pve-manager v2 2/4] sdn: vnet: add isolate-ports option Stefan Hanreich
2024-11-19 16:02   ` [pve-devel] applied: " Thomas Lamprecht
2024-11-12 15:54 ` [pve-devel] [PATCH pve-network v2 3/4] vnets : add ports isolation Stefan Hanreich
2024-11-18 18:46   ` [pve-devel] applied: " Thomas Lamprecht
2024-11-12 15:54 ` [pve-devel] [PATCH pve-docs v2 4/4] sdn: add documentation for isolated ports option Stefan Hanreich
2024-11-18 18:52   ` Stoiko Ivanov
2024-11-19 10:06     ` Hannes Dürr [this message]
2024-11-19 10:19       ` Stoiko Ivanov
2024-11-19 10:34         ` Hannes Dürr
2024-11-12 16:20 ` [pve-devel] applied: [PATCH pve-common v2 1/4] tap_plug: add support for bridge port isolation Thomas Lamprecht
2024-11-18 18:45 ` [pve-devel] " Stoiko Ivanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b8048705-0e89-4480-9249-b100540a1e26@proxmox.com \
    --to=h.duerr@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=s.hanreich@proxmox.com \
    --cc=s.ivanov@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal