Re: [pbs-devel] [PATCH proxmox(-backup), widget-toolkit 0/4] improve ldap configuration handling

[Lukas Wagner <l.wagner@proxmox.com>]

Heya,

reviewed these changes and tested them on the respective latest master branches.
Tested against a `glauth` instance running on my local machine.

Seems to work as advertised. Code looks good to me. Some comments were posted
in reply to the individual patches, but nothing that prohibits a merge IMO.

Consider this:

Tested-by: Lukas Wagner <l.wagner@proxmox.com>
Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>

On 6/26/23 11:39, Stefan Sterz wrote:
> this patch series does two things:
> 
> 1. it improves the creation and updating of ldap configurations by
>     checking it against an ldap directory instead of a regex. thus,
>     increasing the likelihood of the configuration being correct
> 2. remove the ability configure and use unauthenticated binds.
>     unauthenticated binds are generally discouraged and we don't
>     support them in proxmox ve either, so remove them in the backup
>     server too.
> 
> removing unauthenticated binds is a breaking change as some users may
> already rely on this functionality.
> 
> Stefan Sterz (1):
>    window: ldap auth edit forbid specifying a bind_dn without a password
> 
>   src/window/AuthEditLDAP.js | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 

-- 
- Lukas