all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Lorenz Stechauner <l.stechauner@proxmox.com>
Subject: [pve-devel] applied: [PATCH v2 manager] fix #3440: influxdb: remove duplicate vmid tag
Date: Wed, 26 May 2021 17:39:31 +0200	[thread overview]
Message-ID: <b7e648f2-76b1-caf6-e304-de3710fb12bc@proxmox.com> (raw)
In-Reply-To: <20210526092511.45020-1-l.stechauner@proxmox.com>

On 26.05.21 11:25, Lorenz Stechauner wrote:
> remove vmid from data part, it is already contained in object part.
> this is accomplished by adding the parameter $excluded to
> build_influxdb_payload().
> 
> Signed-off-by: Lorenz Stechauner <l.stechauner@proxmox.com>
> ---
> changes to v1:
> - not using `delete` anymore
> - added parameter `excluded` to build_influxdb_payload()
> 

nicer approach indeed.

>  PVE/Status/InfluxDB.pm | 13 ++++++++-----
>  1 file changed, 8 insertions(+), 5 deletions(-)
> 
>

applied, thanks! Followed up with a slight change in comment message, as
the old one read a bit to generic to me.




      reply	other threads:[~2021-05-26 15:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-26  9:25 [pve-devel] " Lorenz Stechauner
2021-05-26 15:39 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b7e648f2-76b1-caf6-e304-de3710fb12bc@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=l.stechauner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal