From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>,
Fiona Ebner <f.ebner@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager] fix #6138: ui: storage content: use locale for sorting filenames
Date: Tue, 4 Mar 2025 14:30:01 +0100 [thread overview]
Message-ID: <b7a52217-7633-4827-b44a-0199b17567e4@proxmox.com> (raw)
In-Reply-To: <e6af83ca-6a03-474e-8118-d7c7ffdfb104@proxmox.com>
Am 04.03.25 um 14:14 schrieb Dominik Csapak:
>> While we're at it, should/can we make sorting numerically work too?
>> There is a 'numeric' option we could set, not sure if that's better or
>> not here and if that is intended to work for mixed strings like
>> soemthing9.yaml, something10.yaml or only for purely numeric ones.
>>
> good catch, from my short testing, yes this seems to work as intended, e.g.
> (copied & adapted from mdn):
>
> console.log("foo2".localeCompare("foo10")); // 1
> console.log("foo2".localeCompare("foo10", undefined, { numeric: true })); // -1
>
> i think using numeric sort here is more "natural",
> even many users already expect it to be sorted lexical i guess
>
> any other opinions on that?
I agree with you and would enable that option too, as it's frontend only we
can always change this if doing so really causes some reasonable complaints.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-03-04 13:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-05 13:22 Dominik Csapak
2025-03-04 13:05 ` Fiona Ebner
2025-03-04 13:14 ` Dominik Csapak
2025-03-04 13:30 ` Thomas Lamprecht [this message]
2025-03-04 14:15 ` Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7a52217-7633-4827-b44a-0199b17567e4@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.