From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Christoph Heiss <c.heiss@proxmox.com>
Subject: [pve-devel] applied: [PATCH installer] tui: tests: fix reading ui messages from low-level installer
Date: Tue, 12 Nov 2024 14:51:32 +0100 [thread overview]
Message-ID: <b749ef40-b2d6-442c-94f0-c4307639d72e@proxmox.com> (raw)
In-Reply-To: <20241112124821.578920-1-c.heiss@proxmox.com>
Am 12.11.24 um 13:48 schrieb Christoph Heiss:
> This actually broke with commit 723afe2 - this patch was quite old
> (18.10.2023) and these tests were introduced some time after sending it,
> thus is not adjusted for it.
>
> Fix itself is pretty simple, simply ignore non-JSON/invalid message from
> the low-level installer, much like the actual progression code does it.
>
> Fixes: 723afe2 ("run env: always re-create run env file in test mode")
> Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> ---
> .../src/views/install_progress.rs | 34 +++++++++++--------
> 1 file changed, 20 insertions(+), 14 deletions(-)
>
>
applied, thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-11-12 13:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-12 12:48 [pve-devel] " Christoph Heiss
2024-11-12 13:51 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b749ef40-b2d6-442c-94f0-c4307639d72e@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.