* [pve-devel] [PATCH storage] clone image: specify base format option with qemu-img
@ 2021-02-04 10:26 Fabian Ebner
2021-04-30 6:38 ` Fabian Ebner
2021-05-03 11:07 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 2 replies; 3+ messages in thread
From: Fabian Ebner @ 2021-02-04 10:26 UTC (permalink / raw)
To: pve-devel
and avoid a warning. It is deprecated to auto-detect the format of the base
volume. See commit d9f059aa6cfccefaffa3532556e966df4a99ece2 in qemu for more
information.
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---
PVE/Storage/GlusterfsPlugin.pm | 2 +-
PVE/Storage/Plugin.pm | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/PVE/Storage/GlusterfsPlugin.pm b/PVE/Storage/GlusterfsPlugin.pm
index 2dd414d..5ec2f42 100644
--- a/PVE/Storage/GlusterfsPlugin.pm
+++ b/PVE/Storage/GlusterfsPlugin.pm
@@ -228,7 +228,7 @@ sub clone_image {
my $volumepath = "gluster://$server/$glustervolume/images/$vmid/$name";
my $cmd = ['/usr/bin/qemu-img', 'create', '-b', "../$basevmid/$basename",
- '-f', 'qcow2', $volumepath];
+ '-F', $format, '-f', 'qcow2', $volumepath];
run_command($cmd, errmsg => "unable to create image");
diff --git a/PVE/Storage/Plugin.pm b/PVE/Storage/Plugin.pm
index d2d8184..bd8b345 100644
--- a/PVE/Storage/Plugin.pm
+++ b/PVE/Storage/Plugin.pm
@@ -708,7 +708,7 @@ sub clone_image {
local $CWD = $imagedir;
my $cmd = ['/usr/bin/qemu-img', 'create', '-b', "../$basevmid/$basename",
- '-f', 'qcow2', $path];
+ '-F', $format, '-f', 'qcow2', $path];
run_command($cmd);
};
--
2.20.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [pve-devel] [PATCH storage] clone image: specify base format option with qemu-img
2021-02-04 10:26 [pve-devel] [PATCH storage] clone image: specify base format option with qemu-img Fabian Ebner
@ 2021-04-30 6:38 ` Fabian Ebner
2021-05-03 11:07 ` [pve-devel] applied: " Thomas Lamprecht
1 sibling, 0 replies; 3+ messages in thread
From: Fabian Ebner @ 2021-04-30 6:38 UTC (permalink / raw)
To: pve-devel
Ping
Am 04.02.21 um 11:26 schrieb Fabian Ebner:
> and avoid a warning. It is deprecated to auto-detect the format of the base
> volume. See commit d9f059aa6cfccefaffa3532556e966df4a99ece2 in qemu for more
> information.
>
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
> PVE/Storage/GlusterfsPlugin.pm | 2 +-
> PVE/Storage/Plugin.pm | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/PVE/Storage/GlusterfsPlugin.pm b/PVE/Storage/GlusterfsPlugin.pm
> index 2dd414d..5ec2f42 100644
> --- a/PVE/Storage/GlusterfsPlugin.pm
> +++ b/PVE/Storage/GlusterfsPlugin.pm
> @@ -228,7 +228,7 @@ sub clone_image {
> my $volumepath = "gluster://$server/$glustervolume/images/$vmid/$name";
>
> my $cmd = ['/usr/bin/qemu-img', 'create', '-b', "../$basevmid/$basename",
> - '-f', 'qcow2', $volumepath];
> + '-F', $format, '-f', 'qcow2', $volumepath];
>
> run_command($cmd, errmsg => "unable to create image");
>
> diff --git a/PVE/Storage/Plugin.pm b/PVE/Storage/Plugin.pm
> index d2d8184..bd8b345 100644
> --- a/PVE/Storage/Plugin.pm
> +++ b/PVE/Storage/Plugin.pm
> @@ -708,7 +708,7 @@ sub clone_image {
> local $CWD = $imagedir;
>
> my $cmd = ['/usr/bin/qemu-img', 'create', '-b', "../$basevmid/$basename",
> - '-f', 'qcow2', $path];
> + '-F', $format, '-f', 'qcow2', $path];
>
> run_command($cmd);
> };
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [pve-devel] applied: [PATCH storage] clone image: specify base format option with qemu-img
2021-02-04 10:26 [pve-devel] [PATCH storage] clone image: specify base format option with qemu-img Fabian Ebner
2021-04-30 6:38 ` Fabian Ebner
@ 2021-05-03 11:07 ` Thomas Lamprecht
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Lamprecht @ 2021-05-03 11:07 UTC (permalink / raw)
To: Proxmox VE development discussion, Fabian Ebner
On 04.02.21 11:26, Fabian Ebner wrote:
> and avoid a warning. It is deprecated to auto-detect the format of the base
> volume. See commit d9f059aa6cfccefaffa3532556e966df4a99ece2 in qemu for more
> information.
>
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
> PVE/Storage/GlusterfsPlugin.pm | 2 +-
> PVE/Storage/Plugin.pm | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-03 11:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-04 10:26 [pve-devel] [PATCH storage] clone image: specify base format option with qemu-img Fabian Ebner
2021-04-30 6:38 ` Fabian Ebner
2021-05-03 11:07 ` [pve-devel] applied: " Thomas Lamprecht
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal