From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Maximiliano Sandoval <m.sandoval@proxmox.com>
Subject: [pve-devel] applied-series: [PATCH installer 1/3] proxinstall: move device changed callback after loop
Date: Thu, 30 Jan 2025 19:12:26 +0100 [thread overview]
Message-ID: <b6f1b121-d847-422c-a2d8-3a26c5903838@proxmox.com> (raw)
In-Reply-To: <20241217152316.381557-1-m.sandoval@proxmox.com>
Am 17.12.24 um 16:23 schrieb Maximiliano Sandoval:
> Otherwise the callback will run once for each NIC.
>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
> proxinstall | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied series, thanks!
I expanded the commit message of the third patch and did an s/proxinstall/gtk ui/
for all subjects. In a separate follow-up commit I also renamed the variables
used for getting the initial state to clarify that they are indeed only holding
initial state. That commit also had a tiny semantic change that I should
have split out: I only set the active value for the combobox if anything is
actually a valid one, similar to how address and mask text fields are handled,
but that should not change anything in practice I think.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-01-30 18:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-17 15:23 [pve-devel] " Maximiliano Sandoval
2024-12-17 15:23 ` [pve-devel] [PATCH installer 2/3] proxinstall: set active element in combo box once Maximiliano Sandoval
2024-12-17 15:23 ` [pve-devel] [PATCH installer 3/3] fix #2502: proxinstall: set cidr text manually Maximiliano Sandoval
2024-12-17 15:26 ` Maximiliano Sandoval
2025-01-30 14:00 ` Maximiliano Sandoval
2025-01-30 18:12 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6f1b121-d847-422c-a2d8-3a26c5903838@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=m.sandoval@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.