From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>, Daniel Kral <d.kral@proxmox.com>
Subject: [pbs-devel] applied-series: [PATCH proxmox-backup v4 1/2] pbs2to3: add test for kernel version compatibility
Date: Tue, 12 Nov 2024 21:22:45 +0100 [thread overview]
Message-ID: <b672daab-2a4d-4f83-9e52-6cb6e0815c89@proxmox.com> (raw)
In-Reply-To: <20240918130100.193090-1-d.kral@proxmox.com>
Am 18.09.24 um 15:00 schrieb Daniel Kral:
> Factors the kernel version compatibility check into its own method and
> adds test cases for a set of expected and unexpected kernel versions.
>
> Signed-off-by: Daniel Kral <d.kral@proxmox.com>
> ---
> Changes to v1/v2/v3:
> - Moved refactoring and test in first commit and changes afterwards
>
> src/bin/pbs2to3.rs | 62 ++++++++++++++++++++++++++++++++++++++++------
> 1 file changed, 55 insertions(+), 7 deletions(-)
>
>
applied both patches, thanks!
albeit, it might be even nicer to just parse out the major and minor parts
of the version and compare them explicitly to a simple const u16 tuple, that
way bumping the minimum kernel might be less headache than coming up with
a new regex.
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2024-11-12 20:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-18 13:00 [pbs-devel] " Daniel Kral
2024-09-18 13:01 ` [pbs-devel] [PATCH proxmox-backup v4 2/2] fix #5600: pbs2to3: allow arbitrary newer '-pve' kernels after upgrade Daniel Kral
2024-11-12 20:22 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b672daab-2a4d-4f83-9e52-6cb6e0815c89@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.kral@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.