From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pve-devel] [PATCH widget-toolkit] RRDTypeSelector: fix extjs debug mode
Date: Fri, 5 Dec 2025 16:16:31 +0100 [thread overview]
Message-ID: <b4d1316a-5438-4d84-a4fa-eb5a8e97275d@proxmox.com> (raw)
In-Reply-To: <20251205143450.2953331-1-d.csapak@proxmox.com>
Am 05.12.25 um 15:34 schrieb Dominik Csapak:
> For some reason, using a space separated list of classes in `itemCls`
> breaks the extjs debug mode. This is seemingly allowed everywhere else,
> so to fix it, simply apply the classes directly to the children
> with 'default'.
This is what I mentioned off-list a two weeks or so ago, I lost track off
it so thx for checking again.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> src/form/RRDTypeSelector.js | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/src/form/RRDTypeSelector.js b/src/form/RRDTypeSelector.js
> index bbb5d86..51ae23a 100644
> --- a/src/form/RRDTypeSelector.js
> +++ b/src/form/RRDTypeSelector.js
> @@ -75,7 +75,9 @@ Ext.define('Proxmox.form.RRDTypeSelector', {
> xtype: 'segmentedbutton',
> allowMultiple: false,
> allowToggle: true,
> - itemCls: 'x-btn-default-toolbar-small proxmox-inline-button',
> + defautl: {
> + cls: 'x-btn-default-toolbar-small proxmox-inline-button',
> + },
using an array makes it work too here:
itemCls: ['x-btn-default-toolbar-small', 'proxmox-inline-button'],
But your variant is probably the slightly nicer one I think.
> items: [
> {
> text: gettext('Maximum'),
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-12-05 15:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-05 14:34 Dominik Csapak
2025-12-05 15:15 ` Max R. Carrara
2025-12-05 15:16 ` Thomas Lamprecht [this message]
2025-12-05 15:34 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4d1316a-5438-4d84-a4fa-eb5a8e97275d@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.