all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pve-devel] [PATCH storage/qemu-server/manager v5] implement ova/ovf import for file based storages
Date: Fri, 15 Nov 2024 16:17:10 +0100	[thread overview]
Message-ID: <b482924d-c3f5-4b2f-b977-95fcebcd05c9@proxmox.com> (raw)
In-Reply-To: <20241114093226.814530-1-d.csapak@proxmox.com>

On 14.11.24 10:32 AM, Dominik Csapak wrote:
> This series enables importing ova/ovf from directory based storages,
> inclusive upload/download via the webui (ova only).
> 
> It also improves the ovf importer by parsing the ostype, nics, bootorder
> (and firmware from vmware exported files).
> 
> I opted to move the OVF.pm to pve-storage, since there is no
> real other place where we could put it. I put it in a new module
> 'GuestImport'
> 
> We now extract the images into either a given target storage or in the
> import storage in the 'images' dir so accidentally left over images
> are discoverable by the ui/cli.
> 
> This version is rebased on fabians hardening series:
> https://lore.proxmox.com/pve-devel/20241104104221.228730-1-f.gruenbichler@proxmox.com/
> 
> So that series is a requirement for this
> 

For the other pve-storage and qemu-server patches I didn't see any
obvious issues, but didn't get around to do an in-depth review.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  parent reply	other threads:[~2024-11-15 15:17 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-14  9:32 Dominik Csapak
2024-11-14  9:32 ` [pve-devel] [PATCH storage v5 01/12] copy OVF.pm from qemu-server Dominik Csapak
2024-11-15 10:37   ` Fiona Ebner
2024-11-14  9:32 ` [pve-devel] [PATCH storage v5 02/12] plugin: dir: implement import content type Dominik Csapak
2024-11-15 11:16   ` Fiona Ebner
2024-11-15 11:24     ` Fiona Ebner
2024-11-15 11:44       ` Dominik Csapak
2024-11-15 11:47     ` Dominik Csapak
2024-11-14  9:32 ` [pve-devel] [PATCH storage v5 03/12] plugin: dir: handle ova files for import Dominik Csapak
2024-11-15 12:11   ` Fiona Ebner
2024-11-15 13:06     ` Dominik Csapak
2024-11-14  9:32 ` [pve-devel] [PATCH storage v5 04/12] ovf: improve and simplify path checking code Dominik Csapak
2024-11-15 13:35   ` Fiona Ebner
2024-11-15 13:39     ` Dominik Csapak
2024-11-15 13:44       ` Fiona Ebner
2024-11-15 13:56         ` Dominik Csapak
2024-11-14  9:32 ` [pve-devel] [PATCH storage v5 05/12] ovf: implement parsing the ostype Dominik Csapak
2024-11-15 13:39   ` Fiona Ebner
2024-11-14  9:32 ` [pve-devel] [PATCH storage v5 06/12] ovf: implement parsing out firmware type Dominik Csapak
2024-11-15 13:44   ` Fiona Ebner
2024-11-14  9:32 ` [pve-devel] [PATCH storage v5 07/12] ovf: implement rudimentary boot order Dominik Csapak
2024-11-15 13:46   ` Fiona Ebner
2024-11-14  9:32 ` [pve-devel] [PATCH storage v5 08/12] ovf: implement parsing nics Dominik Csapak
2024-11-15 13:52   ` Fiona Ebner
2024-11-14  9:32 ` [pve-devel] [PATCH storage v5 09/12] api: allow ova upload/download Dominik Csapak
2024-11-15 14:27   ` Fiona Ebner
2024-11-14  9:32 ` [pve-devel] [PATCH storage v5 10/12] plugin: enable import for nfs/btrfs/cifs/cephfs/glusterfs Dominik Csapak
2024-11-15 14:28   ` Fiona Ebner
2024-11-14  9:32 ` [pve-devel] [PATCH storage v5 11/12] add 'import' content type to 'check_volume_access' Dominik Csapak
2024-11-14  9:32 ` [pve-devel] [PATCH storage v5 12/12] plugin: file_size_info: don't ignore base path with whitespace Dominik Csapak
2024-11-14  9:32 ` [pve-devel] [PATCH qemu-server v5 1/4] api: delete unused OVF.pm Dominik Csapak
2024-11-14  9:32 ` [pve-devel] [PATCH qemu-server v5 2/4] use OVF from Storage Dominik Csapak
2024-11-14  9:32 ` [pve-devel] [PATCH qemu-server v5 3/4] api: create: implement extracting disks when needed for import-from Dominik Csapak
2024-11-15  7:06   ` Dominik Csapak
2024-11-14  9:32 ` [pve-devel] [PATCH qemu-server v5 4/4] api: create: add 'import-extraction-storage' parameter Dominik Csapak
2024-11-14  9:32 ` [pve-devel] [PATCH manager v5 1/9] ui: fix special 'import' icon for non-esxi storages Dominik Csapak
2024-11-14  9:32 ` [pve-devel] [PATCH manager v5 2/9] ui: guest import: add ova-needs-extracting warning text Dominik Csapak
2024-11-14  9:32 ` [pve-devel] [PATCH manager v5 3/9] ui: enable import content type for relevant storages Dominik Csapak
2024-11-14  9:32 ` [pve-devel] [PATCH manager v5 4/9] ui: enable upload/download/remove buttons for 'import' type storages Dominik Csapak
2024-11-14  9:32 ` [pve-devel] [PATCH manager v5 5/9] ui: disable 'import' button for non importable formats Dominik Csapak
2024-11-14  9:32 ` [pve-devel] [PATCH manager v5 6/9] ui: import: improve rendering of volume names Dominik Csapak
2024-11-14  9:32 ` [pve-devel] [PATCH manager v5 7/9] ui: guest import: add storage selector for ova extraction storage Dominik Csapak
2024-11-14  9:32 ` [pve-devel] [PATCH manager v5 8/9] ui: guest import: change icon/text for non-esxi import storage Dominik Csapak
2024-11-14  9:32 ` [pve-devel] [PATCH manager v5 9/9] ui: import: show size for dir-based storages Dominik Csapak
2024-11-15 15:17 ` Fiona Ebner [this message]
2024-11-15 15:22 ` [pve-devel] [PATCH storage/qemu-server/manager v5] implement ova/ovf import for file based storages Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b482924d-c3f5-4b2f-b977-95fcebcd05c9@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal