From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Oguz Bektas <o.bektas@proxmox.com>
Subject: [pve-devel] applied: Re: [PATCH common] cgroup: fix default values for change_cpu_quota (cgroup v1)
Date: Fri, 22 Oct 2021 11:42:16 +0200 [thread overview]
Message-ID: <b47760a1-8945-02b3-e7d5-b7fd7b7d0d0f@proxmox.com> (raw)
In-Reply-To: <20211021143619.1591105-1-o.bektas@proxmox.com>
On 21/10/2021 16:36, Oguz Bektas wrote:
> when period is undefined it should be set to 100ms (default value)
>
> =====
> cpu.cfs_quota_us: the total available run-time within a period (in
> microseconds)
> cpu.cfs_period_us: the length of a period (in microseconds)
> cpu.stat: exports throttling statistics [explained further below]
>
> The default values are:
> cpu.cfs_period_us=100ms
> cpu.cfs_quota=-1
> =====
> see [0]
>
> [0]: https://www.kernel.org/doc/Documentation/scheduler/sched-bwc.txt
>
> Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
> ---
> src/PVE/CGroup.pm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>
applied, thanks! FYI: I amended the commit message a bit, the subject implied
that more than one value was wrong, so I used:
"cgroup: cpu quota: fix resetting period length for v1"
and linked to the non-legacy, now reStructuredText based version of the
docs to a fixed kernel version (I used v5.14 as some docs rendering issues
got fixed in that version and content wise it did not change).
prev parent reply other threads:[~2021-10-22 9:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-21 14:36 [pve-devel] " Oguz Bektas
2021-10-22 9:42 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b47760a1-8945-02b3-e7d5-b7fd7b7d0d0f@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=o.bektas@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.