all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Hannes Laimer <h.laimer@proxmox.com>
Subject: Re: [pve-devel] [PATCH-SERIES v3] fix #3903: remove vmid from jobs.cfg on destroy
Date: Wed, 16 Mar 2022 08:15:57 +0100	[thread overview]
Message-ID: <b3eb1026-78c9-6ad1-b336-4e847e0cc70b@proxmox.com> (raw)
In-Reply-To: <20220314092657.48696-1-h.laimer@proxmox.com>

higher level comment: We cannot do it this way as it adds a cyclic dependency
between pve-container <-> pve-manager and qemu-server <-> pve-manager, which
is not allowed (such things, besides being ugly, make bootstrapping *a lot*
harder, and as I'm most often doing the bootstrap effort I NAK this).
pve-manager must only be a perl-module consumer for other repos, never a
provider.

I mean, it's not like Dominik and I did not predict such things when adding
the Jobs stuff in manager, but neither guest-common (there are guets unrelated
jobs we want to add like (finally) LDAP sync) nor pve-common (to high up the chain
means less access to other modules, e.g., pve-cluster) weren't a really good fitting
place then, especially as we had quite the time pressure, so we added all in
pve-manager as there we have the least coupling for moving it in the future.

I'd actually move the base jobs stuff to pve-cluster (possibly a new binary
package) as that's the highest point we can move it and it's not completely
wrong.




      parent reply	other threads:[~2022-03-16  7:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-14  9:26 Hannes Laimer
2022-03-14  9:26 ` [pve-devel] [PATCH pve-manager v3 1/3] fix #3903: jobs: add remove vmid from jobs helper Hannes Laimer
2022-03-14 10:00   ` Fabian Ebner
2022-03-14 10:18     ` Fabian Ebner
2022-03-15 10:52   ` [pve-devel] [PATCH pve-manager v4 " Hannes Laimer
2022-03-14  9:26 ` [pve-devel] [PATCH pve-container v3 2/3] fix #3903: api2: remove vmid from jobs.cfg Hannes Laimer
2022-03-14  9:26 ` [pve-devel] [PATCH qemu-server v3 3/3] " Hannes Laimer
2022-03-16  7:15 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b3eb1026-78c9-6ad1-b336-4e847e0cc70b@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=h.laimer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal