all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Maximiliano Sandoval R <m.sandoval@proxmox.com>
Subject: [pve-devel] applied: [PATCH installer v3] fix #4869: Show state in management interface ComboBox
Date: Thu, 19 Oct 2023 14:20:46 +0200	[thread overview]
Message-ID: <b38c2180-3c6d-4cad-84c1-da16669d5213@proxmox.com> (raw)
In-Reply-To: <20231019083531.28056-1-m.sandoval@proxmox.com>

Am 19/10/2023 um 10:35 schrieb Maximiliano Sandoval R:
> From: Maximiliano Sandoval <m.sandoval@proxmox.com>
> 
> This is a continuation of
> https://lists.proxmox.com/pipermail/pve-devel/2023-August/058639.html.
> 
> Signed-off-by: Maximiliano Sandoval R <m.sandoval@proxmox.com>
> ---
> v3 was tested only with `make check-pve`. v2 was properly tested by Filip
> Schauer <f.schauer@proxmox.com> in a VM.
> 
> Differences from v2:
>   - Use a escaped utf8 character instead of using `use uft-8;`
> 
> Differences from v1:
>   - Instead of adding a `- UP` or `- DOWN` to the interface label, we display a
>     green BLACK CIRCLE ● similar to what systemd does. To achieve this we
>     separate the GtkWidget in the dropdown in two, and set the color of the new
>     one to green. It was discussed off-list that adding a character for
>     interfaces that were down introduced too much visual noise.
> 
>  proxinstall | 19 +++++++++++++++++--
>  1 file changed, 17 insertions(+), 2 deletions(-)
> 
>

applied, thanks!

I also added this to the TUI, it's important that we keep feature-parity
for those.




      reply	other threads:[~2023-10-19 12:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-19  8:35 [pve-devel] " Maximiliano Sandoval R
2023-10-19 12:20 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b38c2180-3c6d-4cad-84c1-da16669d5213@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=m.sandoval@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal