Re: [PATCH proxmox-backup] fix #7305: client: restore: filter out last snapshot if not finished

[Christian Ebner <c.ebner@proxmox.com>]

On 2/12/26 3:54 PM, Fabian Grünbichler wrote:
> On February 11, 2026 4:24 pm, Christian Ebner wrote:
>> +    // only once a snapshots contains the manifest it is considered finished
>> +    let last_is_finished = list[0]
>> +        .files
>> +        .iter()
>> +        .any(|content| content.filename == MANIFEST_BLOB_NAME.as_ref());
>> +
>> +    if !last_is_finished {
>> +        if list.len() > 1 {
>> +            log::info!("last snapshot of group {group} not finished, use previous instead");
>> +            return Ok((group, list[1].backup.time).into());
>> +        } else {
>> +            bail!("backup group {group} does not contain finished snapshots.");
>> +        }
>> +    }
> 
> couldn't this be a combinator instead?
> 
> i.e., something like
> 
>      let last_finished_time = list
>          .iter()
>          .find_map(|snap| {
>              snap.files.iter().find_map(|content| {
>                  if content.filename == MANIFEST_BLOB_NAME.as_ref() {
>                      Some(snap.backup.time)
>                  } else {
>                      None
>                  }
>              })
>          })
>          .ok_or_else(|| {
>              format_err!("backup group {group} does not contain any finished snapshots.")
>          })?;
> 
> to account for multiple snapshots with missing manifests? those should
> not occur "naturally", but might exist cause of accidents/..

Yes, good point! Would however opt for logging each skipped snapshot 
instead of silently progressing to the next one. This might help debug 
in cases where such issues come up.

Will send version 2 shortly, thanks!