From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: applied: [PATCH qemu-server v2 0/4] rework fs-freeze agent property
Date: Fri, 27 Mar 2026 00:16:16 +0100 [thread overview]
Message-ID: <b2ea6274-809c-48c0-a83b-1cf4f40c9cd1@proxmox.com> (raw)
In-Reply-To: <20260325213415.3861690-1-t.lamprecht@proxmox.com>
Am 25.03.26 um 22:34 schrieb Thomas Lamprecht:
> Sorry for the quick v2 submission, forgot to stage a hunk to complete
> the final patch and applied some of Fiona's patches [0] already so a
> rebase was required anyway.
>
> Somewhat RFC, albeit I'm pretty sure about this the more I think about
> it, even though the transition cost is naturally not great.
>
> Very likely clashes with Fiona's recent QGA-skip-freeze-if-frozen series
> [0], but started this already a few days around and figured it might
> still be relevant in the current form.
>
> I probably would squash in the deprecation of the intermediate
> guest-fsfreeze variant with the commit making the long-time
> freeze-fs-on-backup property an alias to the new variant, which would
> be named 'freeze-fs' hereafter.
>
> Changes v1 -> v2:
> - rebase on master
> - apply hunk to change guest-fsfreeze to freeze-fs in should_fs_freeze
> too in patch 4/4.
>
> Thomas Lamprecht (4):
> agent: add should_fs_freeze helper
> agent: treat freeze-fs-on-backup as alias for guest-fsfreeze
> tests: cfg2cmd: add agent guest-fsfreeze config tests
> qga: rename guest-fsfreeze to freeze-fs
>
> src/PVE/API2/Qemu.pm | 10 +++---
> src/PVE/QemuConfig.pm | 5 ++-
> src/PVE/QemuServer/Agent.pm | 35 ++++++++++++++-----
> src/PVE/VZDump/QemuServer.pm | 6 +---
> .../cfg2cmd/qga-fs-freeze-backup-legacy.conf | 2 ++
> .../qga-fs-freeze-backup-legacy.conf.cmd | 29 +++++++++++++++
> src/test/cfg2cmd/qga-fs-freeze.conf | 2 ++
> src/test/cfg2cmd/qga-fs-freeze.conf.cmd | 29 +++++++++++++++
> src/test/cfg2cmd/qga-minimal.conf | 2 ++
> src/test/cfg2cmd/qga-minimal.conf.cmd | 29 +++++++++++++++
> 10 files changed, 126 insertions(+), 23 deletions(-)
> create mode 100644 src/test/cfg2cmd/qga-fs-freeze-backup-legacy.conf
> create mode 100644 src/test/cfg2cmd/qga-fs-freeze-backup-legacy.conf.cmd
> create mode 100644 src/test/cfg2cmd/qga-fs-freeze.conf
> create mode 100644 src/test/cfg2cmd/qga-fs-freeze.conf.cmd
> create mode 100644 src/test/cfg2cmd/qga-minimal.conf
> create mode 100644 src/test/cfg2cmd/qga-minimal.conf.cmd
>
applied with Fiona's findings and nits addressed and R-b added
prev parent reply other threads:[~2026-03-26 23:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-25 21:28 Thomas Lamprecht
2026-03-25 21:28 ` [PATCH qemu-server v2 1/4] agent: add should_fs_freeze helper Thomas Lamprecht
2026-03-26 12:55 ` Fiona Ebner
2026-03-27 1:12 ` Thomas Lamprecht
2026-03-25 21:28 ` [PATCH qemu-server v2 2/4] agent: treat freeze-fs-on-backup as alias for guest-fsfreeze Thomas Lamprecht
2026-03-26 12:55 ` Fiona Ebner
2026-03-26 23:05 ` Thomas Lamprecht
2026-03-27 8:53 ` Fiona Ebner
2026-03-25 21:28 ` [PATCH qemu-server v2 3/4] tests: cfg2cmd: add agent guest-fsfreeze config tests Thomas Lamprecht
2026-03-26 12:55 ` Fiona Ebner
2026-03-25 21:28 ` [PATCH qemu-server v2 4/4] qga: rename guest-fsfreeze to freeze-fs Thomas Lamprecht
2026-03-26 9:08 ` Maximiliano Sandoval
2026-03-26 21:46 ` Thomas Lamprecht
2026-03-26 12:55 ` Fiona Ebner
2026-03-26 23:16 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2ea6274-809c-48c0-a83b-1cf4f40c9cd1@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.