[pbs-devel] [PATCH v1 proxmox-backup] remove not used argument config from open with path

[pbs-devel] [PATCH v1 proxmox-backup] remove not used argument config from open with path

[Hannes Laimer]

Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---

Building failed since the import of DataStoreConfig was missing,
furthermore config was not used in the function.

 src/backup/datastore.rs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/backup/datastore.rs b/src/backup/datastore.rs
index a856e2f4..47531bbf 100644
--- a/src/backup/datastore.rs
+++ b/src/backup/datastore.rs
@@ -57,7 +57,7 @@ impl DataStore {
             }
         }
 
-        let datastore = DataStore::open_with_path(name, &path, config)?;
+        let datastore = DataStore::open_with_path(name, &path)?;
 
         let datastore = Arc::new(datastore);
         map.insert(name.to_string(), datastore.clone());
@@ -65,7 +65,7 @@ impl DataStore {
         Ok(datastore)
     }
 
-    fn open_with_path(store_name: &str, path: &Path, config: DataStoreConfig) -> Result<Self, Error> {
+    fn open_with_path(store_name: &str, path: &Path) -> Result<Self, Error> {
         let chunk_store = ChunkStore::open(store_name, path)?;
 
         let gc_status = GarbageCollectionStatus::default();
-- 
2.20.1

Re: [pbs-devel] [PATCH v1 proxmox-backup] remove not used argument config from open with path

[Thomas Lamprecht]

On 20.10.20 09:00, Hannes Laimer wrote:
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
> 
> Building failed since the import of DataStoreConfig was missing,
> furthermore config was not used in the function.
> 
>  src/backup/datastore.rs | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/backup/datastore.rs b/src/backup/datastore.rs
> index a856e2f4..47531bbf 100644
> --- a/src/backup/datastore.rs
> +++ b/src/backup/datastore.rs
> @@ -57,7 +57,7 @@ impl DataStore {
>              }
>          }
>  
> -        let datastore = DataStore::open_with_path(name, &path, config)?;
> +        let datastore = DataStore::open_with_path(name, &path)?;
>  
>          let datastore = Arc::new(datastore);
>          map.insert(name.to_string(), datastore.clone());
> @@ -65,7 +65,7 @@ impl DataStore {
>          Ok(datastore)
>      }
>  
> -    fn open_with_path(store_name: &str, path: &Path, config: DataStoreConfig) -> Result<Self, Error> {
> +    fn open_with_path(store_name: &str, path: &Path) -> Result<Self, Error> {
>          let chunk_store = ChunkStore::open(store_name, path)?;
>  
>          let gc_status = GarbageCollectionStatus::default();
> 

looks actually OK and thanks for catching, but it seems Fabian got to it
earlier, and pushed out a fix:
https://git.proxmox.com/?p=proxmox-backup.git;a=commitdiff;h=115d927c15f8c70442de7cc3a43e99587b499c26