From: Filip Schauer <f.schauer@proxmox.com>
To: Fiona Ebner <f.ebner@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH v2 access-control] fix #5136: ldap: Decode non-ASCII characters in attributes
Date: Tue, 9 Jan 2024 14:51:13 +0100 [thread overview]
Message-ID: <b23c679c-92f1-480a-8c07-c0c07c0ef9d1@proxmox.com> (raw)
In-Reply-To: <7d084f1e-fb49-4e45-a671-86635c5301d6@proxmox.com>
I just tried your patch, but it did not fix this specific issue.
On 09/01/2024 14:38, Fiona Ebner wrote:
> Am 09.01.24 um 14:35 schrieb Filip Schauer:
>> UTF8 decode non-ASCII characters when syncing user attributes, since
>> those will be encoded later on. Without this fix the attributes were
>> encoded twice, resulting in cases such as 'ü' turning into 'ü'.
>>
>> Signed-off-by: Filip Schauer <f.schauer@proxmox.com>
> Is this already fixed by avoiding the accidental re-encoding as UTF-8,
> i.e. the following patch:
> https://lists.proxmox.com/pipermail/pve-devel/2024-January/061270.html
> ?
next prev parent reply other threads:[~2024-01-09 13:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-09 13:35 Filip Schauer
2024-01-09 13:38 ` Fiona Ebner
2024-01-09 13:51 ` Filip Schauer [this message]
2024-02-28 14:41 ` Thomas Lamprecht
2024-02-28 15:00 ` Fiona Ebner
2024-02-28 18:58 ` Stoiko Ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b23c679c-92f1-480a-8c07-c0c07c0ef9d1@proxmox.com \
--to=f.schauer@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal