Re: [pbs-devel] [RFC/PATCH proxmox{, -backup} 0/5] tuning: verify: add verify job thread options

[Christian Ebner <c.ebner@proxmox.com>]

On 11/21/25 1:32 PM, Nicolas Frey wrote:
> this patch series aims to expose configuration of the number of threads
> to use for reading and verifying of verify jobs through the datastore's
> tuning options.
> 
> It expands on the series I sent last week [0], where @Thomas
> suggested making this configurable through the tuning options too.
> @Chris suggested adding a dedicated worker thread settings to the
> datastore instead, which is an approach I don't have a problem with,
> but I'd want some more opinions on.
> 
> If the docs should be updated to account for this change, I can either
> send a follow up or do that in a v2.
> 
> Later down the line, it would also be beneficial to add the tape job
> threads to these options, though that is outside of the scope of this
> series.
> 
> [0] https://lore.proxmox.com/pbs-devel/5a731352-1f77-4b15-9a22-7064b70ce519@proxmox.com/T/#t

Nice work!

Gave this series a quick spin an tested:
- that the settings are applied
- edit fields show and update the configured default
- settings are deleted if removed from the config
- verification tasks pick up the configured values
- cli commands for datastore config and verify work as expected

What is still missing is adapting the render_tuning_options in 
www/Utils.js to cover these new parameters as well and adaption to the docs.

Other than that with and a few nit inline to be addressed:

Reviewed-by: Christian Ebner <c.ebner@proxmox.com>
Tested-by: Christian Ebner <c.ebner@proxmox.com>



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel