[pve-devel] [PATCH manager] fix #3689: add gridhandle to firewall rules to indicate drag/drop

[pve-devel] [PATCH manager] fix #3689: add gridhandle to firewall rules to indicate drag/drop

[Dominik Csapak]

dragHandle was copied from the BootOrderEdit.
Also increases the width by 23px to make space for it.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/manager6/grid/FirewallRules.js | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/www/manager6/grid/FirewallRules.js b/www/manager6/grid/FirewallRules.js
index f3e02f6a..1fe13ea6 100644
--- a/www/manager6/grid/FirewallRules.js
+++ b/www/manager6/grid/FirewallRules.js
@@ -623,19 +623,19 @@ Ext.define('PVE.FirewallRules', {
 		// similar to xtype: 'rownumberer',
 		dataIndex: 'pos',
 		resizable: false,
-		minWidth: 42,
-		maxWidth: 60,
+		minWidth: 65,
+		maxWidth: 83,
 		flex: 1,
 		sortable: false,
-		align: 'right',
 		hideable: false,
 		menuDisabled: true,
 		renderer: function(value, metaData, record, rowIdx, colIdx) {
 		    metaData.tdCls = Ext.baseCSSPrefix + 'grid-cell-special';
+		    let dragHandle = "<i class='pve-grid-fa fa fa-fw fa-reorder cursor-move'></i>";
 		    if (value >= 0) {
-			return value;
+			return dragHandle + value;
 		    }
-		    return '';
+		    return dragHandle;
 		},
 	    },
 	    {
-- 
2.30.2

[pve-devel] applied: [PATCH manager] fix #3689: add gridhandle to firewall rules to indicate drag/drop

[Thomas Lamprecht]

On 02.12.21 11:38, Dominik Csapak wrote:
> dragHandle was copied from the BootOrderEdit.
> Also increases the width by 23px to make space for it.
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  www/manager6/grid/FirewallRules.js | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
>

yeah, I forgot and remembered that already like three times in the worst
moments, great to finally have it done!

applied, thanks!