Re: [pve-devel] [RFC qemu-server 3/9] fix #5284: move_vm: add check if target storage supports vm images

[Fiona Ebner <f.ebner@proxmox.com>]

Am 22.01.25 um 14:18 schrieb Daniel Kral:
> On 11/29/24 15:23, Fiona Ebner wrote:
>> Am 16.09.24 um 18:38 schrieb Daniel Kral:
>>> +=head3 check_volume_alloc($storecfg, $storeid, $node)
>>> +
>>> +Checks whether the volume with the identifier C<$volid>, that is
>>> defined in C<$storecfg> (which
>>> +is typically retrieved with L<PVE::Storage::config>), is enabled an
>>> supports volume images.
>>> +
>>> +If the check fails, it will C<die> with an error message.
>>> +
>>> +Returns C<1> if the check is successful.
>>> +
>>> +=cut
>>> +
>>> +sub check_volume_alloc : prototype($$;$) {
>>
>> Again, "assert_" and "_permission"
> 
> Hm, why did you choose permission here?
> 
> There are no permission checks done here, would be a suffix like
> "_allowed" or "_available" also be fine for you?

I was thinking about permissions in a more general sense than our
permission system, but sure, more precise language is better :)



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel