From: Fabian Ebner <f.ebner@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [RFC v2 container 1/1] print_ct_warn_log: use log_warn function from RESTEnvironment
Date: Fri, 4 Mar 2022 11:32:05 +0100 [thread overview]
Message-ID: <b1917d87-180e-ff1a-0e1a-ae2cd2e16d51@proxmox.com> (raw)
In-Reply-To: <41faad7c-490f-0ba4-21b7-ea29cb6b79d9@proxmox.com>
Am 04.03.22 um 11:25 schrieb Thomas Lamprecht:
> On 29/10/2021 13:16, Fabian Ebner wrote:
>> No functional change is intended.
>>
>> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
>> ---
>>
>> No changes from v1.
>>
>> Dependency bump for pve-common is needed.
>
> not any more though, or at least never for the other patch in this series?
> As you do not import the symbol here locally anyway, but always use the full
> module path..
But the function itself only exists after the first patch of the series.
>
>> + PVE::RESTEnvironment::log_warn($1);
>
next prev parent reply other threads:[~2022-03-04 10:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-29 11:16 [pve-devel] [RFC v2 common 1/2] REST environment: add static log_warn function Fabian Ebner
2021-10-29 11:16 ` [pve-devel] [RFC v2 common 2/2] REST environment: allow export of log_warn Fabian Ebner
2022-03-04 10:33 ` [pve-devel] applied: " Thomas Lamprecht
2021-10-29 11:16 ` [pve-devel] [RFC v2 container 1/1] print_ct_warn_log: use log_warn function from RESTEnvironment Fabian Ebner
2022-03-04 10:25 ` Thomas Lamprecht
2022-03-04 10:32 ` Fabian Ebner [this message]
2022-03-04 10:40 ` Thomas Lamprecht
2022-12-14 8:23 ` Fiona Ebner
2022-12-14 11:14 ` [pve-devel] applied: " Thomas Lamprecht
2022-02-16 7:34 ` [pve-devel] [RFC v2 common 1/2] REST environment: add static log_warn function Fabian Ebner
2022-03-04 10:40 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1917d87-180e-ff1a-0e1a-ae2cd2e16d51@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.