From: Aaron Lauterer <a.lauterer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH installer 0/2] tui: throw setup error if no network interfaces were found
Date: Tue, 29 Oct 2024 15:56:11 +0100 [thread overview]
Message-ID: <b0e89112-c4c4-4c16-a6c5-b0bc979fa127@proxmox.com> (raw)
In-Reply-To: <20241024090043.181653-1-c.heiss@proxmox.com>
Tested-By: Aaron Lauterer <a.lauterer@proxmox.com>
On 2024-10-24 11:00, Christoph Heiss wrote:
> Currently, the TUI does not error out like the GUI if no network
> interfaces are found, so remedy that.
>
> Also, while testing, noticed that if an early/setup error is thrown in
> the installer, no background header gets displayed - since it uses a
> completely different screen setup codepath.
>
> Christoph Heiss (2):
> tui: show background header on fatal setup error
> installer-common: throw setup error if no network interfaces were
> found
>
> proxmox-installer-common/src/setup.rs | 2 ++
> proxmox-tui-installer/src/main.rs | 1 +
> 2 files changed, 3 insertions(+)
>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-10-29 14:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-24 9:00 Christoph Heiss
2024-10-24 9:00 ` [pve-devel] [PATCH installer 1/2] tui: show background header on fatal setup error Christoph Heiss
2024-10-24 9:00 ` [pve-devel] [PATCH installer 2/2] installer-common: throw setup error if no network interfaces were found Christoph Heiss
2024-10-29 14:56 ` Aaron Lauterer [this message]
2024-10-30 9:02 ` [pve-devel] applied-series: [PATCH installer 0/2] tui: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0e89112-c4c4-4c16-a6c5-b0bc979fa127@proxmox.com \
--to=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.