From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Lukas Wagner <l.wagner@proxmox.com>
Subject: Re: [pve-devel] [PATCH v2 manager] ui: backup: replication: replace non-clickable checkbox with icons
Date: Tue, 24 Jan 2023 16:28:33 +0100 [thread overview]
Message-ID: <b00f4b14-47cb-5c2b-c811-256be1216bd0@proxmox.com> (raw)
In-Reply-To: <20230123131735.400368-3-l.wagner@proxmox.com>
Am 23/01/2023 um 14:17 schrieb Lukas Wagner:
> From a usability view, having a checkbox that is not clickable is pretty
> misleading, especially if the visual style is exactly the same as in
> other places in the UI where the checkbox is functional.
>
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
> www/manager6/dc/Backup.js | 11 ++++++-----
> www/manager6/grid/Replication.js | 11 +++++++----
> 2 files changed, 13 insertions(+), 9 deletions(-)
>
> diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js
> index 9d305984..8a306330 100644
> --- a/www/manager6/dc/Backup.js
> +++ b/www/manager6/dc/Backup.js
> @@ -784,12 +784,13 @@ Ext.define('PVE.dc.BackupView', {
> {
> header: gettext('Enabled'),
> width: 80,
> - dataIndex: 'enabled',
> - xtype: 'checkcolumn',
> + dataindex: 'enabled',
you break setting dataIndex by writing it all lowercase ?!
> + align: 'center',
> + renderer: function(enabled, cell, record) {
> + return Proxmox.Utils.render_enabled_icon(record.data.enabled);
> + },
with data index fixed, this could be:
renderer: Proxmox.Utils.renderEnabledIcon,
Or if you really want to avoid passing the remaining params to the renderer:
renderer: enabled => Proxmox.Utils.renderEnabledIcon(enabled),
but normally that's really not a problem for renders.
> sortable: true,
> - disabled: true,
> - disabledCls: 'x-item-enabled',
> - stopSelection: false,
> +
> },
> {
> header: gettext('ID'),
> diff --git a/www/manager6/grid/Replication.js b/www/manager6/grid/Replication.js
> index b17288b9..261c2755 100644
> --- a/www/manager6/grid/Replication.js
> +++ b/www/manager6/grid/Replication.js
> @@ -279,11 +279,14 @@ Ext.define('PVE.grid.ReplicaView', {
>
> me.columns = [
> {
> - text: gettext('Enabled'),
> - dataIndex: 'enabled',
> - xtype: 'checkcolumn',
> + header: gettext('Enabled'),
> + width: 80,
> + dataindex: 'enabled',
same here w.r.t. breaking dataIndex
> + align: 'center',
> + renderer: function(enabled, cell, record) {
> + return Proxmox.Utils.render_enabled_icon(record.data.enabled);
> + },
same here w.r.t. shorter direct renderer
> sortable: true,
> - disabled: true,
> },
> {
> text: 'ID',
next prev parent reply other threads:[~2023-01-24 15:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-23 13:17 [pve-devel] [PATCH v2 manager/widget-toolkit 0/2] ui: replace non-clickable checkboxes " Lukas Wagner
2023-01-23 13:17 ` [pve-devel] [PATCH v2 widget-toolkit 1/1] repo view: replace non-clickable checkbox " Lukas Wagner
2023-01-24 15:24 ` Thomas Lamprecht
2023-01-24 15:30 ` Thomas Lamprecht
2023-01-23 13:17 ` [pve-devel] [PATCH v2 manager] ui: backup: replication: " Lukas Wagner
2023-01-24 15:28 ` Thomas Lamprecht [this message]
2023-01-24 15:37 ` Lukas Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b00f4b14-47cb-5c2b-c811-256be1216bd0@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal