From: Gabriel Goller <g.goller@proxmox.com>
To: Robin Christ <robin@rchrist.io>
Cc: pve-devel@lists.proxmox.com, Robin Christ <r.christ@partimus.com>
Subject: Re: [PATCH ifupdown2 4/4] bridge: Fix multiple Single VXLAN Devices in bridge not having tunnel_info applied on first run
Date: Tue, 31 Mar 2026 10:18:52 +0200 [thread overview]
Message-ID: <avw76qeb4kpbobp4i6wqw4clt2pbfnx5732ns52zjpvsfkreru@k3sgknm4ensu> (raw)
In-Reply-To: <20260330213921.533853-5-robin@rchrist.io>
On 30.03.2026 23:39, Robin Christ wrote:
> From: Robin Christ <r.christ@partimus.com>
>
> If you add multiple Single VXLAN Devices to a bridge, only the last one would get the proper
> tunnel_info applied, ultimately resulting in a non-functional network setup.
> This could be fixed by a second execution of ifupdown2.
>
> The reason for this was that the original code was not written with multiple Single VXLAN Devices
> in a single bridge in mind, thus it had only the variable single_vxlan_device_ifaceobj storing
> a single interface that would control the application of tunnel_info the bridge's SVDs.
> Replacing the variable against a list single_vxlan_device_ifaceobjs and adding another little
> loop fixes the issue.
>
> Additionally, some very exhaustive, clarifying information has been added
>
> Signed-off-by: Robin Christ <r.christ@partimus.com>
> ---
> ...tiple-single-vxlan-devices-in-bridge.patch | 101 ++++++++++++++++++
> debian/patches/series | 1 +
> 2 files changed, 102 insertions(+)
> create mode 100644 debian/patches/pve/0019-bridge-fix-multiple-single-vxlan-devices-in-bridge.patch
Thanks for these patches!
If you haven't already, please sign the contribution
agreement and send it to office@proxmox.com
(https://pve.proxmox.com/wiki/Developer_Documentation#Software_License_and_Copyright).
The dry-run patches before look good, maybe @Christoph can have a look at them as well.
About this one though: what is the use-case? we don't use SVDs and so the
tunnel_info property is also not used AFAIK?
next prev parent reply other threads:[~2026-03-31 8:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-30 21:39 [PATCH ifupdown2 0/4] Fix multiple Single VXLAN Devices in bridge and some dry-run fixes Robin Christ
2026-03-30 21:39 ` [PATCH ifupdown2 1/4] nlcache: Fix missing nodad option in addr_add_dry_run Robin Christ
2026-03-30 21:39 ` [PATCH ifupdown2 2/4] nlcache: Add missing link_set_mtu_dry_run method Robin Christ
2026-03-30 21:39 ` [PATCH ifupdown2 3/4] iproute2: Fix bridge_link_update_vni_filter for dry-run Robin Christ
2026-03-30 21:39 ` [PATCH ifupdown2 4/4] bridge: Fix multiple Single VXLAN Devices in bridge not having tunnel_info applied on first run Robin Christ
2026-03-31 8:18 ` Gabriel Goller [this message]
2026-03-31 11:45 ` Robin Christ
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avw76qeb4kpbobp4i6wqw4clt2pbfnx5732ns52zjpvsfkreru@k3sgknm4ensu \
--to=g.goller@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=r.christ@partimus.com \
--cc=robin@rchrist.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.