From: Gabriel Goller <g.goller@proxmox.com>
To: Stefan Hanreich <s.hanreich@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [PATCH proxmox-ve-rs v3 07/32] sdn: allow static routes in simple zone VRFs
Date: Wed, 18 Nov 2026 19:10:57 +0100 [thread overview]
Message-ID: <av3iR9l_5F0iD048@luna.proxmox.com> (raw)
In-Reply-To: <e4b8ec67-ba41-42bc-ae8d-bec5ed7e8d2d@proxmox.com>
On 18.11.2026 16:29, Stefan Hanreich wrote:
>
>
> On 11/16/26 5:16 PM, Gabriel Goller wrote:
> > Allow simple zones to reach upstream networks through zone-wide static
> > routes, without requiring node-local FRR overrides. Install routes in
> > vrf_<zone> when dedicated-vrf is enabled, or in the default routing table
> > otherwise. Only generate routes on nodes that belong to the zone.
> >
> > Support IPv4 and IPv6 routes, with an optional outgoing interface,
> > administrative distance and next-hop VRF. The next-hop VRF only selects
> > where to resolve the gateway; the route still belongs to the zone.
> >
> > Reject prefixes with host bits set, since staticd normalizes them and
> > frr-reload would otherwise replace them on every reload. Keep the perl
> > vrf field as the outgoing interface for existing EVPN routes, separate
> > from the VRF in which the route is installed.
>
> Can't we just normalize them ourselves before writing them out and then
> accept anything with host bits set?
Hmm yeah so we do that with the fabric prefix (normalize in the api, then
write the normalized prefix to config) but there the prefix doesn't have such a
weight, it's basically just a way to restrict the node-ips. Here on the other
hand, we actually route the prefix, so IMO a 10.10.10.125/24 is more a typo
(also because the prefix actually has some weight here, not like with the
fabrics).
> [...]
>
> > +/// Routing-related properties of a single SDN zone.
> > +#[derive(Clone, Debug, Deserialize)]
> > +pub struct ZoneRoutes {
> > + #[serde(rename = "type")]
> > + pub ty: String,
> > + #[serde(
> > + default,
> > + rename = "dedicated-vrf",
> > + deserialize_with = "proxmox_serde::perl::deserialize_bool"
> > + )]
> > + pub dedicated_vrf: bool,
> > + pub nodes: Option<BTreeMap<String, serde_json::Value>>,
> > + #[serde(default)]
> > + pub route: Vec<PropertyString<StaticRoute>>,
>
> We need to write this property canonicalized in Perl, as otherwise this can cause
> deserialization issues with values the API accepts, as I've learned the hard way D:
Hmm ok I get it. We should this everywhere though, we don't this in dhcp-ranges afaik...
> > +}
> > +
> > +#[cfg(feature = "frr")]
> > +impl ZoneRoutesConfig {
> > + /// Generate routes only on nodes participating in the zone.
> > + pub fn routes_for_node(&self, node: &str) -> Result<Vec<proxmox_frr::ser::IpRoute>, Error> {
>
> can we skip invalid routes instead of erroring out here? It'd abort the whole FRR config
> generation..
Makes sense.
> > + use proxmox_frr::ser::{InterfaceName as FrrInterfaceName, IpOrInterface, IpRoute};
> > +
> > + let to_frr = |name: &InterfaceName| FrrInterfaceName::try_from(name.as_str());
> > +
> > + let mut routes = Vec::new();
> > + for (zone, config) in &self.ids {
> > + if config.route.is_empty() {
> > + continue;
> > + }
> > + if config.ty != "simple" {
> > + bail!("static routes are only supported in simple zones (zone '{zone}')");
> > + }
> > + if config
> > + .nodes
> > + .as_ref()
> > + .is_some_and(|nodes| !nodes.contains_key(node))
> > + {
> > + continue;
> > + }
> > + let destination_vrf = config
> > + .dedicated_vrf
> > + .then(|| FrrInterfaceName::try_from(format!("vrf_{zone}")))
> > + .transpose()?;
> > + for route in &config.route {
> > + route.validate()?;
> > + let mut frr_route = IpRoute::new(route.prefix, route.via.map(IpOrInterface::Ip));
> > + frr_route.iface = route.iface.as_ref().map(to_frr).transpose()?;
> > + frr_route.distance = route.distance;
> > + frr_route.nexthop_vrf = route.nexthop_vrf.as_ref().map(to_frr).transpose()?;
> > + frr_route.destination_vrf = destination_vrf.clone();
> > + routes.push(frr_route);
> > + }
> > + }
> > + Ok(routes)
> > + }
> > +}
next prev parent reply other threads:[~2026-11-18 18:11 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 16:11 [PATCH common/manager/network/proxmox{-ve-rs,-perl-rs,-widget-toolkit} v3 00/32] SDN VRF support Gabriel Goller
2026-11-16 16:11 ` [PATCH pve-common v3 01/32] interfaces: preserve VRF membership across address family changes Gabriel Goller
2026-11-18 14:13 ` Stefan Hanreich
2026-11-18 15:41 ` Gabriel Goller
2026-11-16 16:11 ` [PATCH proxmox-ve-rs v3 02/32] frr: add VRF-aware OSPF rendering Gabriel Goller
2026-11-18 14:41 ` Stefan Hanreich
2026-11-18 16:21 ` Gabriel Goller
2026-11-16 16:11 ` [PATCH proxmox-ve-rs v3 03/32] sdn: add zone references to OSPF and BGP fabrics Gabriel Goller
2026-11-18 14:10 ` Stefan Hanreich
2026-11-18 16:55 ` Gabriel Goller
2026-11-16 16:11 ` [PATCH proxmox-ve-rs v3 04/32] sdn: generate fabric routing configuration in zone VRFs Gabriel Goller
2026-11-18 14:53 ` Stefan Hanreich
2026-11-18 17:26 ` Gabriel Goller
2026-11-16 16:11 ` [PATCH proxmox-ve-rs v3 05/32] sdn: fix VRF route-map scoping and zone ID validation Gabriel Goller
2026-11-16 16:11 ` [PATCH proxmox-ve-rs v3 06/32] tests: fabrics: add test for fabrics in VRFs Gabriel Goller
2026-11-18 15:01 ` Stefan Hanreich
2026-11-18 17:33 ` Gabriel Goller
2026-11-16 16:11 ` [PATCH proxmox-ve-rs v3 07/32] sdn: allow static routes in simple zone VRFs Gabriel Goller
2026-11-18 15:29 ` Stefan Hanreich
2026-11-18 18:10 ` Gabriel Goller [this message]
2026-11-16 16:11 ` [PATCH proxmox-ve-rs v3 08/32] sdn: support static routes in EVPN " Gabriel Goller
2026-11-18 15:32 ` Stefan Hanreich
2026-11-19 13:12 ` Gabriel Goller
2026-11-16 16:11 ` [PATCH proxmox-perl-rs v3 09/32] pve-rs: fabrics: assign network interfaces to configured VRFs Gabriel Goller
2026-11-16 16:11 ` [PATCH proxmox-perl-rs v3 10/32] pve-rs: fabrics: make per-fabric status queries VRF-aware Gabriel Goller
2026-11-18 15:42 ` Stefan Hanreich
2026-11-19 13:30 ` Gabriel Goller
2026-11-16 16:11 ` [PATCH proxmox-perl-rs v3 11/32] pve-rs: fabrics: include VRF routes in aggregate status Gabriel Goller
2026-11-16 16:11 ` [PATCH proxmox-perl-rs v3 12/32] pve-rs: fabrics: expose host interface membership Gabriel Goller
2026-11-16 16:11 ` [PATCH proxmox-perl-rs v3 13/32] sdn: expose static routes for simple zone uplinks Gabriel Goller
2026-11-16 16:11 ` [PATCH pve-network v3 14/32] sdn: evpn: add unreachable IPv6 default route to zone VRFs Gabriel Goller
2026-11-18 16:08 ` Stefan Hanreich
2026-11-18 16:39 ` Stefan Hanreich
2026-11-19 13:38 ` Gabriel Goller
2026-11-19 15:51 ` Gabriel Goller
2026-11-16 16:11 ` [PATCH pve-network v3 15/32] sdn: add optional VRFs for simple zones Gabriel Goller
2026-11-18 16:18 ` Stefan Hanreich
2026-11-19 13:44 ` Gabriel Goller
2026-11-16 16:11 ` [PATCH pve-network v3 16/32] sdn: allow fabrics to use simple zone VRFs Gabriel Goller
2026-11-18 16:27 ` Stefan Hanreich
2026-11-19 14:14 ` Gabriel Goller
2026-11-16 16:11 ` [PATCH pve-network v3 17/32] sdn: require underlay fabrics to use the default VRF Gabriel Goller
2026-11-18 16:30 ` Stefan Hanreich
2026-11-19 14:33 ` Gabriel Goller
2026-11-16 16:11 ` [PATCH pve-network v3 18/32] sdn: always generate EVPN zone VRFs Gabriel Goller
2026-11-16 16:11 ` [PATCH pve-network v3 19/32] api: sdn: allow EVPN zones as fabric VRFs Gabriel Goller
2026-11-16 16:11 ` [PATCH pve-network v3 20/32] api: sdn: disallow BGP fabrics in EVPN zone VRFs Gabriel Goller
2026-11-16 16:11 ` [PATCH pve-network v3 21/32] sdn: simple: support static routes in zone routing tables Gabriel Goller
2026-11-18 16:49 ` Stefan Hanreich
2026-11-19 14:53 ` Gabriel Goller
2026-11-16 16:11 ` [PATCH pve-network v3 22/32] sdn: evpn: allow static routes Gabriel Goller
2026-11-16 16:11 ` [PATCH pve-network v3 23/32] sdn: zones: SNAT via dedicated uplinks in zone VRFs Gabriel Goller
2026-11-18 18:07 ` Stefan Hanreich
2026-11-16 16:11 ` [PATCH pve-network v3 24/32] sdn: dhcp: only configure DHCP for zones on the local node Gabriel Goller
2026-11-16 16:11 ` [PATCH pve-network v3 25/32] sdn: dhcp: run dnsmasq in the zone VRF Gabriel Goller
2026-11-16 16:11 ` [PATCH proxmox-widget-toolkit v3 26/32] ui: network: allow selecting a VRF for host interfaces Gabriel Goller
2026-11-16 16:11 ` [PATCH pve-manager v3 27/32] ui: sdn: add VRF zone selection for fabrics Gabriel Goller
2026-11-16 16:11 ` [PATCH pve-manager v3 28/32] ui: sdn: expose EVPN zones as fabric VRFs Gabriel Goller
2026-11-16 16:11 ` [PATCH pve-manager v3 29/32] network: allow setting the VRF of host interfaces Gabriel Goller
2026-11-16 16:11 ` [PATCH pve-manager v3 30/32] ui: sdn: allow static routes for Simple zone VRFs Gabriel Goller
2026-11-16 16:11 ` [PATCH pve-manager v3 31/32] ui: sdn: allow static routes in EVPN zones Gabriel Goller
2026-11-16 16:11 ` [PATCH pve-manager v3 32/32] network: generate SDN DHCP config after ifreload Gabriel Goller
2026-11-18 18:27 ` [PATCH common/manager/network/proxmox{-ve-rs,-perl-rs,-widget-toolkit} v3 00/32] SDN VRF support Stefan Hanreich
2026-11-19 15:33 ` Gabriel Goller
2026-11-19 20:10 ` Gabriel Goller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=av3iR9l_5F0iD048@luna.proxmox.com \
--to=g.goller@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.hanreich@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.