* [pbs-devel] [PATCH proxmox-backup v2] datastore: add warning comment to unsafe function
@ 2024-07-04 11:20 Gabriel Goller
2025-01-14 8:45 ` Gabriel Goller
0 siblings, 1 reply; 2+ messages in thread
From: Gabriel Goller @ 2024-07-04 11:20 UTC (permalink / raw)
To: pbs-devel
`list_snapshots_blocking` is unsafe only to imply it's specific behavior.
Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
---
src/api2/admin/datastore.rs | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/api2/admin/datastore.rs b/src/api2/admin/datastore.rs
index 82221c503d16..4a04d9821edd 100644
--- a/src/api2/admin/datastore.rs
+++ b/src/api2/admin/datastore.rs
@@ -458,7 +458,8 @@ pub async fn list_snapshots(
.map_err(|err| format_err!("failed to await blocking task: {err}"))?
}
-/// This must not run in a main worker thread as it potentially does tons of I/O.
+/// WARNING: Do not run in main worker thread as this potentially does a ton of I/O.
+/// This function has also been marked as `unsafe` to warn about this behavior.
unsafe fn list_snapshots_blocking(
store: String,
ns: Option<BackupNamespace>,
--
2.43.0
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [pbs-devel] [PATCH proxmox-backup v2] datastore: add warning comment to unsafe function
2024-07-04 11:20 [pbs-devel] [PATCH proxmox-backup v2] datastore: add warning comment to unsafe function Gabriel Goller
@ 2025-01-14 8:45 ` Gabriel Goller
0 siblings, 0 replies; 2+ messages in thread
From: Gabriel Goller @ 2025-01-14 8:45 UTC (permalink / raw)
To: pbs-devel
bump
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-01-14 8:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-07-04 11:20 [pbs-devel] [PATCH proxmox-backup v2] datastore: add warning comment to unsafe function Gabriel Goller
2025-01-14 8:45 ` Gabriel Goller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.