Re: [PATCH perl-rs 2/3] common: enable strict and warnings in perl package modules

[Wolfgang Bumiller <w.bumiller@proxmox.com>]

On Thu, Oct 15, 2026 at 05:42:40PM +0200, Lukas Sichert wrote:
> The Proxmox style guide requires every perl module to enable both
> pragmas, but PVE::RS::CalendarEvent and Proxmox::Lib::Common did not.
> 
> Signed-off-by: Lukas Sichert <l.sichert@proxmox.com>
> ---
>  common/pkg/PVE/RS/CalendarEvent.pm | 3 +++
>  common/pkg/Proxmox/Lib/Common.pm   | 3 +++
>  2 files changed, 6 insertions(+)
> 
> diff --git a/common/pkg/PVE/RS/CalendarEvent.pm b/common/pkg/PVE/RS/CalendarEvent.pm
> index 3a5f66e..47946f8 100644
> --- a/common/pkg/PVE/RS/CalendarEvent.pm
> +++ b/common/pkg/PVE/RS/CalendarEvent.pm
> @@ -1,3 +1,6 @@
> +use strict;
> +use warnings;
> +

This is rather useless in this file.

This is a deprecated file of which the last user, as far as I can tell,
was fixed 4 years ago, so we should delete it instead.

>  use base 'Proxmox::RS::CalendarEvent';
>  # Compat, Deprecated!
>  1
> diff --git a/common/pkg/Proxmox/Lib/Common.pm b/common/pkg/Proxmox/Lib/Common.pm
> index 1e6b26d..1074050 100644
> --- a/common/pkg/Proxmox/Lib/Common.pm
> +++ b/common/pkg/Proxmox/Lib/Common.pm
> @@ -22,6 +22,9 @@ whichever was loaded.
>  
>  =cut
>  
> +use strict;
> +use warnings;
> +
>  use vars qw(@ISA);
>  
>  sub library {
> -- 
> 2.47.3
> 
> 
> 
> 
> 

--