all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Lukas Sichert <l.sichert@proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: Lukas Sichert <l.sichert@proxmox.com>
Subject: [PATCH perl-rs 2/3] common: enable strict and warnings in perl package modules
Date: Thu, 15 Oct 2026 17:42:40 +0200	[thread overview]
Message-ID: <20261015154243.304235-3-l.sichert@proxmox.com> (raw)
In-Reply-To: <20261015154243.304235-1-l.sichert@proxmox.com>

The Proxmox style guide requires every perl module to enable both
pragmas, but PVE::RS::CalendarEvent and Proxmox::Lib::Common did not.

Signed-off-by: Lukas Sichert <l.sichert@proxmox.com>
---
 common/pkg/PVE/RS/CalendarEvent.pm | 3 +++
 common/pkg/Proxmox/Lib/Common.pm   | 3 +++
 2 files changed, 6 insertions(+)

diff --git a/common/pkg/PVE/RS/CalendarEvent.pm b/common/pkg/PVE/RS/CalendarEvent.pm
index 3a5f66e..47946f8 100644
--- a/common/pkg/PVE/RS/CalendarEvent.pm
+++ b/common/pkg/PVE/RS/CalendarEvent.pm
@@ -1,3 +1,6 @@
+use strict;
+use warnings;
+
 use base 'Proxmox::RS::CalendarEvent';
 # Compat, Deprecated!
 1
diff --git a/common/pkg/Proxmox/Lib/Common.pm b/common/pkg/Proxmox/Lib/Common.pm
index 1e6b26d..1074050 100644
--- a/common/pkg/Proxmox/Lib/Common.pm
+++ b/common/pkg/Proxmox/Lib/Common.pm
@@ -22,6 +22,9 @@ whichever was loaded.
 
 =cut
 
+use strict;
+use warnings;
+
 use vars qw(@ISA);
 
 sub library {
-- 
2.47.3





  parent reply	other threads:[~2026-10-15 15:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-15 15:42 [PATCH network/perl-rs/proxmox 0/3] perl: enable strict and warnings in modules that lack them Lukas Sichert
2026-10-15 15:42 ` [PATCH network 1/3] api: zones: enable strict and warnings Lukas Sichert
2026-10-15 15:42 ` Lukas Sichert [this message]
2026-10-16 13:43   ` [PATCH perl-rs 2/3] common: enable strict and warnings in perl package modules Wolfgang Bumiller
2026-10-15 15:42 ` [PATCH proxmox 3/3] pve-api-types: enable strict and warnings in Bool Lukas Sichert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261015154243.304235-3-l.sichert@proxmox.com \
    --to=l.sichert@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal