all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Lukas Sichert <l.sichert@proxmox.com>, pdm-devel@lists.proxmox.com
Subject: Re: [PATCH proxmox 1/4] fix #7315: generate: add support for new certificate variant
Date: Mon, 9 Mar 2026 21:05:23 +0100	[thread overview]
Message-ID: <af32a918-0241-459b-a6d3-619f9915ed66@proxmox.com> (raw)
In-Reply-To: <20260302134537.108696-2-l.sichert@proxmox.com>

no biggie, but subject would be IMO slightly nicer if written as:

pve-api-types: vm config: add support for new OVMF MS cert variant

while that is a bit condensed, it still gives me much more context about
what's touched here.

Am 02.03.26 um 14:45 schrieb Lukas Sichert:
> Since the last time the types.rs has been generated a new Windows
> certificate variant was added. As no mapping for this variant to a rust
> enum exits, generating the types fails.
> 
> To add support for this variant, add a mapping from the Perl definition
> to a Rust enum.
> 
> Signed-off-by: Lukas Sichert <l.sichert@proxmox.com>
> ---
>  pve-api-types/generate.pl | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/pve-api-types/generate.pl b/pve-api-types/generate.pl
> index e5c5d051..ba732e9d 100755
> --- a/pve-api-types/generate.pl
> +++ b/pve-api-types/generate.pl
> @@ -94,6 +94,7 @@ Schema2Rust::register_enum_variant('QemuConfigEfidisk0Efitype::2m' => 'Mb2');
>  Schema2Rust::register_enum_variant('QemuConfigEfidisk0Efitype::4m' => 'Mb4');
>  Schema2Rust::register_enum_variant('QemuConfigEfidisk0MsCert::2011' => 'CA2011');
>  Schema2Rust::register_enum_variant('QemuConfigEfidisk0MsCert::2023' => 'CA2023');
> +Schema2Rust::register_enum_variant('QemuConfigEfidisk0MsCert::2023w' => 'CA2023w');
>  Schema2Rust::register_enum_variant('QemuConfigHugepages::2' => 'Mb2');
>  Schema2Rust::register_enum_variant('QemuConfigHugepages::1024' => 'Mb1024');
>  Schema2Rust::register_enum_variant('PveQmRngSource::/dev/urandom', => 'DevUrandom');





  reply	other threads:[~2026-03-09 20:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-02 13:45 [PATCH api-types/manager/datacenter-manager 0/4] fix #7315: datacenter-manager: fix wrong calculation of total storage Lukas Sichert
2026-03-02 13:45 ` [PATCH proxmox 1/4] fix #7315: generate: add support for new certificate variant Lukas Sichert
2026-03-09 20:05   ` Thomas Lamprecht [this message]
2026-03-02 13:45 ` SPAM: [PATCH proxmox 2/4] fix #7315: run make refresh Lukas Sichert
2026-03-09 15:48   ` Thomas Lamprecht
2026-03-02 13:45 ` [PATCH manager 3/4] fix #7315: types: add missing storage flag to json schema Lukas Sichert
2026-03-02 13:51   ` Dominik Rusovac
2026-03-02 13:45 ` [PATCH datacenter-manager 4/4] fix #7135: ui: correct calculations for shared storages Lukas Sichert
2026-03-09 22:06   ` applied: " Thomas Lamprecht
2026-03-09 20:35 ` partially-applied: [PATCH api-types/manager/datacenter-manager 0/4] fix #7315: datacenter-manager: fix wrong calculation of total storage Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=af32a918-0241-459b-a6d3-619f9915ed66@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=l.sichert@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal