all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Lorenz Stechauner <l.stechauner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager v3 0/7] multi disk/mp in wizard
Date: Tue, 19 Oct 2021 15:53:58 +0200	[thread overview]
Message-ID: <aee51b65-252f-a94b-dd99-1dcf93abec2c@proxmox.com> (raw)
In-Reply-To: <20211005112903.3649291-1-d.csapak@proxmox.com>

Hi,

everything looks and works as expected. No disk/mount point window looks 
broken.

Tested VM/CT creation wizard and adding of disks/mount points afterwards.

Tested-By: Lorenz Stechauner <l.stechauner@proxmox.com>

On 05.10.21 13:28, Dominik Csapak wrote:
> this series is a continuation of my previous multi tab / disk series[0]
>
> Introduces multi disk panels for vm and containers in the wizard.
>
> The UX is modeled after Dominics first attempt, but a very different
> approach code-wise. instead of having a seperate 'data' panel that
> contains the vm config, let the multi disk panel handle that
> and pass it through to the panels below. this way the HDEdit does
> not need a big code-change to get/set the config.
>
> changes from v2:
> * rebase on master (multi tab disk panel already applied)
> * refactor multi disk panel so that we can reuse it for containers
> * implement multi mp panel for container
>
> changes from v1:
> * fixed a bug which prevented the wizard from finishing
> * made the wizard a little wider so that the form field labes are
>    readable
> * added logic to use the ostype to determine the first disk if one
>    deleted all before
>
> 0: https://lists.proxmox.com/pipermail/pve-devel/2021-October/050215.html
>
> Dominik Csapak (7):
>    ui: lxc/MPEdit: add updateVMConfig
>    ui: lxc/MPEdit: fire diskidchange event
>    ui: lxc/MPEdit: add selectFree toggle
>    ui: add MultiDiskPanel
>    ui: add lxc/MultiMPEdit and use in lxc/CreateWizard
>    ui: add qemu/MultiHDEdit and use it in the wizard
>    ui: window/Wizard: make it a little wider
>
>   www/manager6/Makefile               |   3 +
>   www/manager6/lxc/CreateWizard.js    |   8 +-
>   www/manager6/lxc/MPEdit.js          |  16 +-
>   www/manager6/lxc/MultiMPEdit.js     |  79 ++++++++
>   www/manager6/panel/MultiDiskEdit.js | 272 ++++++++++++++++++++++++++++
>   www/manager6/qemu/CreateWizard.js   |   7 +-
>   www/manager6/qemu/HDEdit.js         |   9 +-
>   www/manager6/qemu/MultiHDEdit.js    |  62 +++++++
>   www/manager6/window/Wizard.js       |   2 +-
>   9 files changed, 444 insertions(+), 14 deletions(-)
>   create mode 100644 www/manager6/lxc/MultiMPEdit.js
>   create mode 100644 www/manager6/panel/MultiDiskEdit.js
>   create mode 100644 www/manager6/qemu/MultiHDEdit.js
>




  parent reply	other threads:[~2021-10-19 13:54 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-05 11:28 Dominik Csapak
2021-10-05 11:28 ` [pve-devel] [PATCH manager v3 1/7] ui: lxc/MPEdit: add updateVMConfig Dominik Csapak
2021-10-05 11:28 ` [pve-devel] [PATCH manager v3 2/7] ui: lxc/MPEdit: fire diskidchange event Dominik Csapak
2021-10-05 11:28 ` [pve-devel] [PATCH manager v3 3/7] ui: lxc/MPEdit: add selectFree toggle Dominik Csapak
2021-10-05 11:29 ` [pve-devel] [PATCH manager v3 4/7] ui: add MultiDiskPanel Dominik Csapak
2021-10-05 11:29 ` [pve-devel] [PATCH manager v3 5/7] ui: add lxc/MultiMPEdit and use in lxc/CreateWizard Dominik Csapak
2021-10-05 11:29 ` [pve-devel] [PATCH manager v3 6/7] ui: add qemu/MultiHDEdit and use it in the wizard Dominik Csapak
2021-10-05 11:29 ` [pve-devel] [PATCH manager v3 7/7] ui: window/Wizard: make it a little wider Dominik Csapak
2021-10-19 13:53 ` Lorenz Stechauner [this message]
2021-10-20 10:10 ` [pve-devel] [PATCH manager v3 0/7] multi disk/mp in wizard Aaron Lauterer
2021-11-05 13:13 ` [pve-devel] applied-series: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aee51b65-252f-a94b-dd99-1dcf93abec2c@proxmox.com \
    --to=l.stechauner@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal