all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH access-control v2] add missing paths in check_path
@ 2021-06-16 13:55 Dominik Csapak
  2021-06-16 14:19 ` [pve-devel] applied: " Thomas Lamprecht
  2021-06-16 14:27 ` [pve-devel] " Thomas Lamprecht
  0 siblings, 2 replies; 3+ messages in thread
From: Dominik Csapak @ 2021-06-16 13:55 UTC (permalink / raw)
  To: pve-devel

* /access/realm/<realm>
* /access/groups/<group>

were overlooked when fixing #1500

see: https://forum.proxmox.com/threads/are-group-acls-broken-in-v6-4.91000/

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
supersedes my earlier patch:
https://lists.proxmox.com/pipermail/pve-devel/2021-June/048704.html

changes:
* also add missing group paths

 src/PVE/AccessControl.pm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/PVE/AccessControl.pm b/src/PVE/AccessControl.pm
index 888875e..9619c7d 100644
--- a/src/PVE/AccessControl.pm
+++ b/src/PVE/AccessControl.pm
@@ -939,7 +939,9 @@ sub check_path {
 	/
 	|/access
 	|/access/groups
+	|/access/groups/[[:alnum:]\.\-\_]+
 	|/access/realm
+	|/access/realm/[[:alnum:]\.\-\_]+
 	|/nodes
 	|/nodes/[[:alnum:]\.\-\_]+
 	|/pool
-- 
2.20.1





^ permalink raw reply	[flat|nested] 3+ messages in thread

* [pve-devel] applied: [PATCH access-control v2] add missing paths in check_path
  2021-06-16 13:55 [pve-devel] [PATCH access-control v2] add missing paths in check_path Dominik Csapak
@ 2021-06-16 14:19 ` Thomas Lamprecht
  2021-06-16 14:27 ` [pve-devel] " Thomas Lamprecht
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Lamprecht @ 2021-06-16 14:19 UTC (permalink / raw)
  To: Proxmox VE development discussion, Dominik Csapak

On 16.06.21 15:55, Dominik Csapak wrote:
> * /access/realm/<realm>
> * /access/groups/<group>
> 
> were overlooked when fixing #1500
> 
> see: https://forum.proxmox.com/threads/are-group-acls-broken-in-v6-4.91000/
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> supersedes my earlier patch:
> https://lists.proxmox.com/pipermail/pve-devel/2021-June/048704.html
> 
> changes:
> * also add missing group paths
> 
>  src/PVE/AccessControl.pm | 2 ++
>  1 file changed, 2 insertions(+)
> 
>

applied, thanks!




^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [pve-devel] [PATCH access-control v2] add missing paths in check_path
  2021-06-16 13:55 [pve-devel] [PATCH access-control v2] add missing paths in check_path Dominik Csapak
  2021-06-16 14:19 ` [pve-devel] applied: " Thomas Lamprecht
@ 2021-06-16 14:27 ` Thomas Lamprecht
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Lamprecht @ 2021-06-16 14:27 UTC (permalink / raw)
  To: Proxmox VE development discussion, Dominik Csapak

On 16.06.21 15:55, Dominik Csapak wrote:
> * /access/realm/<realm>
> * /access/groups/<group>
> 
> were overlooked when fixing #1500
> 
> see: https://forum.proxmox.com/threads/are-group-acls-broken-in-v6-4.91000/
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> supersedes my earlier patch:
> https://lists.proxmox.com/pipermail/pve-devel/2021-June/048704.html
> 
> changes:
> * also add missing group paths
> 
>  src/PVE/AccessControl.pm | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/PVE/AccessControl.pm b/src/PVE/AccessControl.pm
> index 888875e..9619c7d 100644
> --- a/src/PVE/AccessControl.pm
> +++ b/src/PVE/AccessControl.pm
> @@ -939,7 +939,9 @@ sub check_path {
>  	/
>  	|/access
>  	|/access/groups
> +	|/access/groups/[[:alnum:]\.\-\_]+
>  	|/access/realm
> +	|/access/realm/[[:alnum:]\.\-\_]+
>  	|/nodes
>  	|/nodes/[[:alnum:]\.\-\_]+
>  	|/pool
> 

also backported to stable-6, and those sub-paths are missing in the UI's
"path proposal" generator for the combobox's store, can you please send a
patch to add them there too (master only)?




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-06-16 14:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-16 13:55 [pve-devel] [PATCH access-control v2] add missing paths in check_path Dominik Csapak
2021-06-16 14:19 ` [pve-devel] applied: " Thomas Lamprecht
2021-06-16 14:27 ` [pve-devel] " Thomas Lamprecht

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal