From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stoiko Ivanov <s.ivanov@proxmox.com>
Subject: [pve-devel] applied series: [PATCH manger/container v2 0/2] detect containers not supporting pure cgroupv2
Date: Mon, 5 Jul 2021 18:59:35 +0200 [thread overview]
Message-ID: <aeb1ce75-5d6f-be2d-32aa-df4718902b15@proxmox.com> (raw)
In-Reply-To: <20210705105717.779369-1-s.ivanov@proxmox.com>
On 05.07.21 12:57, Stoiko Ivanov wrote:
> changes v1->v2:
> incorporated Thomas' feedback (huge thx!) by:
> * adding extra handling for Alpine and Devuan container (patch 2/2 for
> pve-container)
> * copying the helpers directly to pve6to7 to avoid versioned dependency
> bumps
> * refactoring the code in pve6to7 a bit (also returning early for
> Alpine/Devuan)
> * adding a 'full' parameter (would be grateful for suggestions for a better
> fitting name) and only running this expensive check if it is provided
> (patch 2/2 for pve-manager)
>
> original cover-letter for v1:
> This series addresses the issue of running containers, which boot with a
> systemd version which is too old (<232) to support the unified cgroup
> hierarchy - This includes CentOS 7 and Ubuntu 16.04 containers.
>
> The patch for pve-container simply logs to syslog with level err to notify
> the user. Since container start runs through our stack into systemd
> (and back into our stack), I did not see a better option (grateful for
> feedback if there is of course).
>
> One alternative might be to mount the container once in vm_start (or the
> API calls), check and unmount again - but this seemed a bit expensive to do
> unconditionally on every start.
>
> The patch for pve6to7 simply loops through all containers and checks for
> the condition
>
> pve-container:
> Stoiko Ivanov (2):
> prestart-hook: detect cgroupv2 incompatible systemd version
> setup: shortcut cgroupv2 support for non-systemd distros
>
> src/PVE/LXC/Setup.pm | 8 ++++++++
> src/PVE/LXC/Setup/Alpine.pm | 7 +++++++
> src/PVE/LXC/Setup/Base.pm | 36 ++++++++++++++++++++++++++++++++++++
> src/PVE/LXC/Setup/Devuan.pm | 7 +++++++
> src/lxc-pve-prestart-hook | 7 +++++++
> 5 files changed, 65 insertions(+)
>
> pve-manger:
> Stoiko Ivanov (2):
> pve6to7: check for containers not supporting pure cgroupv2
> pve6to7: add 'full' parameter for expensive checks
>
> PVE/CLI/pve6to7.pm | 138 ++++++++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 135 insertions(+), 3 deletions(-)
>
applied series, thanks!
prev parent reply other threads:[~2021-07-05 17:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-05 10:57 [pve-devel] " Stoiko Ivanov
2021-07-05 10:57 ` [pve-devel] [PATCH container v2 1/2] prestart-hook: detect cgroupv2 incompatible systemd version Stoiko Ivanov
2021-07-05 10:57 ` [pve-devel] [PATCH container v2 2/2] setup: shortcut cgroupv2 support for non-systemd distros Stoiko Ivanov
2021-07-05 10:57 ` [pve-devel] [PATCH manager v2 1/2] pve6to7: check for containers not supporting pure cgroupv2 Stoiko Ivanov
2021-07-05 10:57 ` [pve-devel] [PATCH manager v2 2/2] pve6to7: add 'full' parameter for expensive checks Stoiko Ivanov
2021-07-05 16:59 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aeb1ce75-5d6f-be2d-32aa-df4718902b15@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.ivanov@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal