[pve-devel] [PATCH v5 manager 1/2] GUI: HDEdit: check iothread by default and move it from advanced section

[pve-devel] [PATCH v5 manager 1/2] GUI: HDEdit: check iothread by default and move it from advanced section

[Matthias Heiserer]

Existing disks are not changed by this.
Especially in benchmarks, iothreads significantly improve IO performance.

Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
---

Changes from v4:
* also check iothread for VirtIO block devices

Changes from v3:
* remove automatically switching to/from SCSI single when iothread is (un)checked
* iothread will be initially set on
* changing the controller to something other than SCSI single and then back to
  SCSI single will enable iothread for all SCSI disks.

Changes from v2:
* also check iothread when adding a disk to an existing VM

 www/manager6/qemu/HDEdit.js | 31 ++++++++++++++++---------------
 1 file changed, 16 insertions(+), 15 deletions(-)

diff --git a/www/manager6/qemu/HDEdit.js b/www/manager6/qemu/HDEdit.js
index 4e4d6aac..921bfe72 100644
--- a/www/manager6/qemu/HDEdit.js
+++ b/www/manager6/qemu/HDEdit.js
@@ -14,6 +14,7 @@ Ext.define('PVE.qemu.HDInputPanel', {
 	data: {
 	    isSCSI: false,
 	    isVirtIO: false,
+	    isSCSISingle: false,
 	},
     },
 
@@ -44,13 +45,10 @@ Ext.define('PVE.qemu.HDInputPanel', {
 	    'field[name=deviceid]': {
 		change: 'fireIdChange',
 	    },
-	    'field[name=iothread]': {
+	    'field[name=scsiController]': {
 		change: function(f, value) {
-		    if (!this.getView().insideWizard) {
-			return;
-		    }
-		    var vmScsiType = value ? 'virtio-scsi-single': 'virtio-scsi-pci';
-		    this.lookupReference('scsiController').setValue(vmScsiType);
+		    let vm = this.getViewModel();
+		    vm.set('isSCSISingle', value === 'virtio-scsi-single');
 		},
 	    },
 	},
@@ -195,6 +193,7 @@ Ext.define('PVE.qemu.HDInputPanel', {
 	    me.scsiController = Ext.create('Ext.form.field.Display', {
 		fieldLabel: gettext('SCSI Controller'),
 		reference: 'scsiController',
+		name: 'scsiController',
 		bind: me.insideWizard ? {
 		    value: '{current.scsihw}',
 		    visible: '{isSCSI}',
@@ -251,6 +250,17 @@ Ext.define('PVE.qemu.HDInputPanel', {
 		reference: 'discard',
 		name: 'discard',
 	    },
+	    {
+		xtype: 'proxmoxcheckbox',
+		name: 'iothread',
+		fieldLabel: 'IO thread',
+		clearOnDisable: true,
+		bind: {
+		    disabled: '{!isVirtIO && !isSCSI}',
+		    // Checkbox.setValue handles Arrays in a different way, therefore cast to bool
+		    value: '{!!isVirtIO || (isSCSI && isSCSISingle)}',
+		},
+	    },
 	);
 
 	advancedColumn1.push(
@@ -263,15 +273,6 @@ Ext.define('PVE.qemu.HDInputPanel', {
 		    disabled: '{isVirtIO}',
 		},
 	    },
-	    {
-		xtype: 'proxmoxcheckbox',
-		name: 'iothread',
-		fieldLabel: 'IO thread',
-		clearOnDisable: true,
-		bind: {
-		    disabled: '{!isVirtIO && !isSCSI}',
-		},
-	    },
 	    {
 		xtype: 'proxmoxcheckbox',
 		name: 'readOnly', // `ro` in the config, we map in get/set values
-- 
2.30.2

[pve-devel] [PATCH v5 manager 2/2] GUI: OS defaults: use SCSI single as default controller

[Matthias Heiserer]

Existing installs are not changed by this.

Reviewed-by: Fabian Ebner <f.ebner@proxmox.com>
Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
---

No changes from v1/v2/v3/v4

 www/manager6/qemu/OSDefaults.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/manager6/qemu/OSDefaults.js b/www/manager6/qemu/OSDefaults.js
index eed9eebc..5e588a58 100644
--- a/www/manager6/qemu/OSDefaults.js
+++ b/www/manager6/qemu/OSDefaults.js
@@ -42,7 +42,7 @@ Ext.define('PVE.qemu.OSDefaults', {
 		    scsi: 2,
 		    virtio: 1,
 	    },
-	    scsihw: 'virtio-scsi-pci',
+	    scsihw: 'virtio-scsi-single',
 	};
 
        // virtio-net is in kernel since 2.6.25
-- 
2.30.2

[pve-devel] [PATCH v5 qemu-server 1/2] d/control: bump dependency of libpve-common-perl

[Matthias Heiserer]

We require log_warn to show warnings in the UI for unlikely iothread configurations.

Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
---

Changes from v4:
* reword commit message
* also bump installation dependency

Changes from v3:
* None

Changes from v1/v2:
* new patch

 debian/control | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/debian/control b/debian/control
index af258db..a90ecd6 100644
--- a/debian/control
+++ b/debian/control
@@ -7,7 +7,7 @@ Build-Depends: debhelper (>= 12~),
                libio-multiplex-perl,
                libjson-c-dev,
                libpve-cluster-perl,
-               libpve-common-perl (>= 7.1-3),
+               libpve-common-perl (>= 7.1-4),
                libpve-guest-common-perl (>= 4.1-1),
                libpve-storage-perl (>= 6.1-7),
                libtest-mockmodule-perl,
@@ -35,7 +35,7 @@ Depends: dbus,
          libnet-ssleay-perl,
          libpve-access-control (>= 5.0-7),
          libpve-cluster-perl,
-         libpve-common-perl (>= 7.1-3),
+         libpve-common-perl (>= 7.1-4),
          libpve-guest-common-perl (>= 4.1-1),
          libpve-storage-perl (>= 6.3-8),
          libterm-readline-gnu-perl,
-- 
2.30.2

[pve-devel] [PATCH v5 qemu-server 2/2] fix #3890 - GUI: warn for unlikely iothread config

[Matthias Heiserer]

Previously, only a plaintext line in the task log showed something was off.
Now, the GUI will show it as a warning.

Reviewed-by: Fabian Ebner <f.ebner@proxmox.com>
Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
---

changes from v4:
* reorder import alphabetically

Changes from v3:
* None

changes from v2:
* locally import PVE::RestEnv log_warn


 PVE/QemuServer.pm | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index e9aa248..aebfee8 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -36,6 +36,7 @@ use PVE::INotify;
 use PVE::JSONSchema qw(get_standard_option parse_property_string);
 use PVE::ProcFSTools;
 use PVE::PBSClient;
+use PVE::RESTEnvironment qw(log_warn);
 use PVE::RPCEnvironment;
 use PVE::Storage;
 use PVE::SysFSTools;
@@ -3961,7 +3962,9 @@ sub config_to_command {
 		$iothread .= ",iothread=iothread-$controller_prefix$controller";
 		push @$cmd, '-object', "iothread,id=iothread-$controller_prefix$controller";
 	    } elsif ($drive->{iothread}) {
-		warn "iothread is only valid with virtio disk or virtio-scsi-single controller, ignoring\n";
+		log_warn(
+		    "iothread is only valid with virtio disk or virtio-scsi-single controller, ignoring\n"
+		);
 	    }
 
 	    my $queues = '';
-- 
2.30.2

[pve-devel] applied: [PATCH v5 manager 1/2] GUI: HDEdit: check iothread by default and move it from advanced section

[Thomas Lamprecht]

Am 13/06/2022 um 15:54 schrieb Matthias Heiserer:
> Existing disks are not changed by this.
> Especially in benchmarks, iothreads significantly improve IO performance.
> 
> Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
> ---
> 
> Changes from v4:
> * also check iothread for VirtIO block devices
> 
> Changes from v3:
> * remove automatically switching to/from SCSI single when iothread is (un)checked
> * iothread will be initially set on
> * changing the controller to something other than SCSI single and then back to
>   SCSI single will enable iothread for all SCSI disks.
> 
> Changes from v2:
> * also check iothread when adding a disk to an existing VM
> 
>  www/manager6/qemu/HDEdit.js | 31 ++++++++++++++++---------------
>  1 file changed, 16 insertions(+), 15 deletions(-)
> 
>

applied series (we recently bumped the version for pve-common dependency in d/control,
so that patch got unnecessary now), thanks!