From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Matthias Heiserer <m.heiserer@proxmox.com>
Subject: [pve-devel] applied: [PATCH v5 manager 1/2] GUI: HDEdit: check iothread by default and move it from advanced section
Date: Tue, 8 Nov 2022 17:52:11 +0100 [thread overview]
Message-ID: <ae9b3a41-593d-644b-a489-a0fe8f899af4@proxmox.com> (raw)
In-Reply-To: <20220613135425.1800809-1-m.heiserer@proxmox.com>
Am 13/06/2022 um 15:54 schrieb Matthias Heiserer:
> Existing disks are not changed by this.
> Especially in benchmarks, iothreads significantly improve IO performance.
>
> Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
> ---
>
> Changes from v4:
> * also check iothread for VirtIO block devices
>
> Changes from v3:
> * remove automatically switching to/from SCSI single when iothread is (un)checked
> * iothread will be initially set on
> * changing the controller to something other than SCSI single and then back to
> SCSI single will enable iothread for all SCSI disks.
>
> Changes from v2:
> * also check iothread when adding a disk to an existing VM
>
> www/manager6/qemu/HDEdit.js | 31 ++++++++++++++++---------------
> 1 file changed, 16 insertions(+), 15 deletions(-)
>
>
applied series (we recently bumped the version for pve-common dependency in d/control,
so that patch got unnecessary now), thanks!
prev parent reply other threads:[~2022-11-08 16:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-13 13:54 [pve-devel] " Matthias Heiserer
2022-06-13 13:54 ` [pve-devel] [PATCH v5 manager 2/2] GUI: OS defaults: use SCSI single as default controller Matthias Heiserer
2022-06-13 13:54 ` [pve-devel] [PATCH v5 qemu-server 1/2] d/control: bump dependency of libpve-common-perl Matthias Heiserer
2022-06-13 13:54 ` [pve-devel] [PATCH v5 qemu-server 2/2] fix #3890 - GUI: warn for unlikely iothread config Matthias Heiserer
2022-11-08 16:52 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae9b3a41-593d-644b-a489-a0fe8f899af4@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=m.heiserer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal