From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fiona Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied: [PATCH qemu-server] drive mirror: prevent wrongly logging success when completion fails differently
Date: Tue, 30 Jul 2024 21:18:30 +0200 [thread overview]
Message-ID: <ae384005-2258-48dd-991c-638c5f356d9b@proxmox.com> (raw)
In-Reply-To: <20240723120759.73454-1-f.ebner@proxmox.com>
Am 23/07/2024 um 14:07 schrieb Fiona Ebner:
> Currently, when completing a drive mirror job, only errors matching
> "cannot be completed" will be handled. Other errors are ignored and
> a wrong message that the job was completed successfully will be
> printed to the log. An instance of this popped up in the community
> forum [0].
>
> The QMP command used for completing the job is either
> 'block-job-complete' or 'block-job-cancel'. The former causes the VM
> to switch to the target drive, the latter doesn't, e.g. migration uses
> the latter to not switch the source instance over to the target drive.
> The 'block-job-cancel' command doesn't even have the same "cannot be
> completed" message, but returns immediately.
>
> The timeout for both 'block-job-cancel' and 'block-job-complete' is
> set to 10 minutes in the QMPClient module, which should be enough.
>
> [0]: https://forum.proxmox.com/threads/151518/
>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
> PVE/QemuServer.pm | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
applied, thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-07-30 19:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-23 12:07 [pve-devel] " Fiona Ebner
2024-07-30 19:18 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae384005-2258-48dd-991c-638c5f356d9b@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.