all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>,
	Gabriel Goller <g.goller@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup v2] fix #4823: datastore: ignore vanished files when walking directory
Date: Mon, 18 Sep 2023 16:44:17 +0200	[thread overview]
Message-ID: <ae24e585-2722-47b4-b533-f3ef87d4279c@proxmox.com> (raw)
In-Reply-To: <20230908125610.226464-1-g.goller@proxmox.com>

Am 08/09/2023 um 14:56 schrieb Gabriel Goller:
> When walking through a datastore on a GC run, it can
> happen that the snapshot is deleted, and then walked over.
> For example:
> - read dir entry for group
> - walk entries (snapshots)
> - snapshot X is removed/pruned
> - walking reaches snapshot X, but ENOENT
> Previously we bailed here, now we just ignore it.
> Backups that are just created (and a atomic rename from
> tmpdir happens, which might triggers a ENOENT error) are
> not a problem here, the GC handles them separately.
> 
> Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
> ---
> 
> update v2:
>  - rebased, added log message
> 
>  pbs-datastore/src/datastore.rs | 3 +++
>  1 file changed, 3 insertions(+)
> 
>

applied, thanks!




      reply	other threads:[~2023-09-18 14:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-08 12:56 [pbs-devel] " Gabriel Goller
2023-09-18 14:44 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ae24e585-2722-47b4-b533-f3ef87d4279c@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=g.goller@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal