From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Aaron Lauterer <a.lauterer@proxmox.com>
Subject: [pve-devel] applied-series: Re: [PATCH v3 storage 0/2] RBD/Cephfs: new keyring parameter
Date: Thu, 26 Aug 2021 18:17:10 +0200 [thread overview]
Message-ID: <ade33b7d-951d-f5c9-ce3c-5b620527b512@proxmox.com> (raw)
In-Reply-To: <20210826100332.2003299-1-a.lauterer@proxmox.com>
On 26/08/2021 12:03, Aaron Lauterer wrote:
> This new parameter allows to set the RBD keyring or CephFS secret for an
> external Ceph Cluster right when creating the storage.
> Up until now, they had to be manually placed in
> /etc/pve/priv/ceph/$file.
>
> In order to reuse as much code as possible, I had to adjust the
> PVE::CephConfig::ceph_create_keyfile method to be able to pass the
> secret in as parameter.
>
> changes since v2: rebased and hopefully omit adding unintentional
> characters ;)
> changes since v1: fixed checks to avoid accidentially deleting the
> keyring/secret file
>
> Aaron Lauterer (2):
> CephConfig: add optional $secret parameter
> Ceph: add keyring parameter for external clusters
>
> PVE/API2/Storage/Config.pm | 2 +-
> PVE/CLI/pvesm.pm | 12 ++++++++++--
> PVE/CephConfig.pm | 15 +++++++++------
> PVE/Storage/CephFSPlugin.pm | 22 ++++++++++++++++------
> PVE/Storage/RBDPlugin.pm | 26 ++++++++++++++++++++------
> 5 files changed, 56 insertions(+), 21 deletions(-)
>
applied both patches, thanks!
prev parent reply other threads:[~2021-08-26 16:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-26 10:03 [pve-devel] " Aaron Lauterer
2021-08-26 10:03 ` [pve-devel] [PATCH v3 storage 1/2] CephConfig: add optional $secret parameter Aaron Lauterer
2021-08-26 10:03 ` [pve-devel] [PATCH v3 storage 2/2] Ceph: add keyring parameter for external clusters Aaron Lauterer
2021-08-26 16:17 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ade33b7d-951d-f5c9-ce3c-5b620527b512@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.