From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
"Michael Köppl" <m.koeppl@proxmox.com>
Subject: Re: [pve-devel] [PATCH FOLLOW-UP manager/widget-toolkit 0/2] replace SafeDestroy
Date: Tue, 30 Sep 2025 12:00:45 +0200 [thread overview]
Message-ID: <ac51b6ff-c717-4db1-b17d-e86b66cda039@proxmox.com> (raw)
In-Reply-To: <20250924161714.434858-1-m.koeppl@proxmox.com>
Am 24.09.25 um 18:17 schrieb Michael Köppl:
> The ConfirmRemoveDialog window covers the SafeDestroy window's
> functionality, but makes it more general-purpose/flexible. It can be
> used for both yes/no dialog as well as the SafeDestroy dialogs already
> used for guests/storages. The reason for adding ConfirmRemoveDialog was
> that Ext.Msg.MessageBox is not properly extendable and simply adding an
> additional dialog would result in duplicate functionality covered in
> both SafeDestroy and ConfirmRemoveDialog. Thus, replace SafeDestroy with
> ConfirmRemoveDialog.
Why not keep SafeDestroy but make it base off the new ConfirmRemoveDialog
so that it's basically just a very thin wrapper that does not cost us
much to have? It's frequently used after all, so going that route would
reduce churn quite a bit.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-09-30 10:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-24 16:17 Michael Köppl
2025-09-24 16:17 ` [pve-devel] [PATCH FOLLOW-UP widget-toolkit 1/1] window: remove SafeDestroy Michael Köppl
2025-09-24 16:17 ` [pve-devel] [PATCH FOLLOW-UP manager 1/1] ui: replace SafeDestroy with ConfirmRemoveDialog Michael Köppl
2025-09-26 14:08 ` Daniel Kral
2025-09-30 8:04 ` Michael Köppl
2025-09-30 10:00 ` Thomas Lamprecht [this message]
2025-09-30 11:23 ` [pve-devel] [PATCH FOLLOW-UP manager/widget-toolkit 0/2] replace SafeDestroy Michael Köppl
2025-09-30 15:00 ` Michael Köppl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac51b6ff-c717-4db1-b17d-e86b66cda039@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=m.koeppl@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.