[pbs-devel] applied: [PATCH proxmox-backup v2] api: tape: don't allow overwriting of ids in changer/drive config

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

Am 06/03/2024 um 10:39 schrieb Dominik Csapak:
> by checking the whole section config for an existing id, not only the
> ones of the given type.
> 
> This prevents creation of a drive config with the same name as an
> existing changer and vice versa, as it is confusing that existing things
> get deleted, and we can get in the situation that we reference a changer
> that does not exist anymore, i.e. consider this:
> 
> * create a changer with name `foo`
> * create a drive with name `foo` and select changer `foo` for it
> 
> this would delete the changer config, but still reference it, leading
> to errors when trying to use it.
> 
> We could implement support for separate id namespaces in section configs
> for different types, but this is much more easier to do and be enough
> for now.
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> If we decide to implement different id namespaces in the section config
> later, then this commit can be reverted.
> 
>  src/api2/config/changer.rs | 8 ++++----
>  src/api2/config/drive.rs   | 7 ++++---
>  2 files changed, 8 insertions(+), 7 deletions(-)
> 
>

applied, thanks!


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel