all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Maximiliano Sandoval <m.sandoval@proxmox.com>
Subject: [pve-devel] applied-series: [PATCH manager v2 1/2] ceph: mark global pg bits setting as deprecated
Date: Sun, 12 Nov 2023 18:18:04 +0100	[thread overview]
Message-ID: <ab161640-3de1-4552-ade6-e9854a342fa2@proxmox.com> (raw)
In-Reply-To: <20230922092526.152176-1-m.sandoval@proxmox.com>

Am 22/09/2023 um 11:25 schrieb Maximiliano Sandoval:
> This setting was removed in [1] as part of the v13.0.2 tag. Running
> 
>     ceph config set global osd_pg_bits 42
> 
> results in
> 
>     Error EINVAL: unrecognized config option 'osd_pg_bits'
> 
> So we mark this api as deprecated and make it a no-op operation.
> 
> [1] https://github.com/ceph/ceph/commit/e6acf2d1d528a2395947d446a57bec04a3a002dc
> 
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
> 
> Since this an API call, its hard for clients to get a warning thats logged on
> the server and I opted for just marking the API as deprecated in its
> description.
> 
> Differences from v1:
>   - Instead of removing the api, mark it as deprecated
> 
>  PVE/API2/Ceph.pm | 10 +++-------
>  1 file changed, 3 insertions(+), 7 deletions(-)
> 
>

applied both patches, thanks!




      parent reply	other threads:[~2023-11-12 17:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-22  9:25 [pve-devel] " Maximiliano Sandoval
2023-09-22  9:25 ` [pve-devel] [PATCH manager v2 2/2] ceph: api: use snake_case when setting options Maximiliano Sandoval
2023-11-10 12:45   ` Maximiliano Sandoval
2023-11-12 17:18 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ab161640-3de1-4552-ade6-e9854a342fa2@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=m.sandoval@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal