From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Philipp Hufnagl <p.hufnagl@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup v7] ui: fix #4260: add dynamic notes in backup group comment
Date: Fri, 13 Oct 2023 17:39:34 +0200 [thread overview]
Message-ID: <aad85007-eea1-4d7e-8acc-21ea54d29953@proxmox.com> (raw)
In-Reply-To: <20231013143755.2549025-1-p.hufnagl@proxmox.com>
Am 13/10/2023 um 16:37 schrieb Philipp Hufnagl:
> When there is no comment for a backup group, the comment of the last
> snapshot in this group will be shown slightly grayed out as long as
> the group is collapsed.
>
> Signed-off-by: Philipp Hufnagl <p.hufnagl@proxmox.com>
> ---
>
> Changes since v1:
> * code quality improvements
> * remove unused variable
>
>
> www/css/ext6-pbs.css | 4 ++++
> www/datastore/Content.js | 14 +++++++++++---
> 2 files changed, 15 insertions(+), 3 deletions(-)
>
>
applied, thanks!
But I renamed the utility class name to "pmx-opacity-75" in a follow-up,
(and as the name suggest set the value to three/quarters) as faded sounded
a bit weird to me and wasn't really telling, first I thought about using
"dimmed", then "dimmed-opacity", and finally I just figured to follow the
"Nomen est omen" saying and use a very telling name.
prev parent reply other threads:[~2023-10-13 15:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-13 14:37 [pbs-devel] " Philipp Hufnagl
2023-10-13 15:39 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aad85007-eea1-4d7e-8acc-21ea54d29953@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=p.hufnagl@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.