From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fiona Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied: [PATCH qemu] Makefile: drop -j option from dpkg-buildpackage
Date: Thu, 18 Apr 2024 22:18:13 +0200 [thread overview]
Message-ID: <aab391d5-3140-4625-9199-d350578d6b76@proxmox.com> (raw)
In-Reply-To: <20240412122640.146893-1-f.ebner@proxmox.com>
Am 12/04/2024 um 14:26 schrieb Fiona Ebner:
> From man dpkg-buildpackage:
>
>> -j, --jobs[=jobs|auto]
>> Specifies the number of jobs allowed to be run simultaneously (since
>> dpkg 1.14.7, long option since dpkg 1.18.8). The number of jobs
>> matching the number of online processors if auto is specified (since
>> dpkg 1.17.10), or unlimited number if jobs is not specified. The
>> default behavior is auto (since dpkg 1.18.11) in non-forced mode
>> (since dpkg 1.21.10), and as such it is always safer to use with any
>> package including those that are not parallel-build safe.
>
> The option was added in the Makefile by commit 4ba321f ("build qemu
> multithreaded") which states:
>
>> same as in pve-kernel where we have --jobs=auto
>
> But according to the man page, -j without an argument is not the same
> and means unlimited. Using the number of online cores seems more
> sensible and was the original intention. Again, according to the man
> page, the default is auto since dpkg 1.18.11 (or Debian Stretch), so
> just drop the option.
>
> The motivation to look into this was that after the recent upstream
> commit d1ce2cc95b ("Makefile: preserve --jobserver-auth argument when
> calling ninja") having -j as the make flag would be broken as it was
> mistakenly passed to ninja (for which the argument for -j is not
> optional). Should get fixed soon [0].
>
> [0]: https://lore.kernel.org/qemu-devel/20240412100401.20047-2-pbonzini@redhat.com/T/#u
>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-04-18 20:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 12:26 [pve-devel] " Fiona Ebner
2024-04-18 20:18 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aab391d5-3140-4625-9199-d350578d6b76@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.