From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH novnc] parse error 'already started' on guest start
Date: Thu, 24 Feb 2022 13:38:20 +0100 [thread overview]
Message-ID: <aa486428-6c67-b54d-3580-b6e7767d3c84@proxmox.com> (raw)
In-Reply-To: <20220222153350.1808592-1-d.csapak@proxmox.com>
On 22.02.22 16:33, Dominik Csapak wrote:
> when we start an already started container, we get an error instead
> of a task that fails
>
> so to have similar behaviour between vm and ct, we parse that error
> for the start command and behave like it was successful
>
> put it in the first patch and rebase the rest of them
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> .../0001-add-PVE-specific-JS-code.patch | 19 ++++++++++++++-----
> .../0012-pass-custom-command-to-vnc.patch | 2 +-
> ...passing-deprecated-upgrade-parameter.patch | 2 +-
> ...-create-own-class-for-hidden-buttons.patch | 6 +++---
> ...-button-on-isFullscreen-get-variable.patch | 4 ++--
> ...ow-start-button-on-not-running-vm-ct.patch | 8 ++++----
> 6 files changed, 25 insertions(+), 16 deletions(-)
>
>
applied, with the commit subject/message fixed up, thanks!
prev parent reply other threads:[~2022-02-24 12:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-22 15:33 [pve-devel] " Dominik Csapak
2022-02-22 15:46 ` Dominik Csapak
2022-02-24 12:38 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa486428-6c67-b54d-3580-b6e7767d3c84@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.