Re: [PATCH ha-manager v2 3/4] fix #2751: implement disarm-ha and arm-ha for safe cluster maintenance

[Fiona Ebner <f.ebner@proxmox.com>]

Am 22.03.26 um 12:57 AM schrieb Thomas Lamprecht:
> +    if ($mode eq 'freeze') {
> +        for my $sid (sort keys %$ss) {
> +            my $sd = $ss->{$sid};
> +            my $state = $sd->{state};
> +            next if $state eq 'freeze'; # already frozen
> +            if (
> +                $state eq 'started'
> +                || $state eq 'stopped'
> +                || $state eq 'request_stop'
> +                || $state eq 'request_start'
> +                || $state eq 'request_start_balance'
> +                || $state eq 'error'

Should it really happen for the 'error' state too? Because when
re-arming, the state will become 'started':

Mar 25 16:20:06 pve9a1 pve-ha-crm[242553]: disarm: freezing service
'vm:400' (was 'error')
...
Mar 25 16:20:36 pve9a1 pve-ha-crm[242553]: service 'vm:400': state
changed from 'freeze' to 'started'

Which feels rather surprising to me. For comparison, after a cold
cluster start, services in 'error' state are not (attempted to be)
started either.

> +            ) {
> +                $haenv->log('info', "disarm: freezing service '$sid' (was '$state')");
> +                delete $sd->{$_} for grep { !$keep_keys{$_} } keys %$sd;
> +                $sd->{state} = 'freeze';
> +                $sd->{uid} = compute_new_uuid('freeze');
> +            }
> +        }