From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Stoiko Ivanov <s.ivanov@proxmox.com>, pmg-devel@lists.proxmox.com
Subject: [pmg-devel] applied: [PATCH pmg-gui 2/4] quarantine: contextmenu: refactor for use in other quarantines
Date: Sat, 22 Oct 2022 16:32:10 +0200 [thread overview]
Message-ID: <a9e26ded-e131-44f4-b10d-e5116d2e8eff@proxmox.com> (raw)
In-Reply-To: <20221020191500.2414-3-s.ivanov@proxmox.com>
Am 20/10/2022 um 21:14 schrieb Stoiko Ivanov:
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
> can/should probably be squashed with the next patch
>
no, it's better separate.
> js/Makefile | 1 +
> js/QuarantineContextMenu.js | 32 ++++++++++++++++++++++++++++++++
> js/SpamContextMenu.js | 14 +-------------
> 3 files changed, 34 insertions(+), 13 deletions(-)
> create mode 100644 js/QuarantineContextMenu.js
>
>
applied, thanks! fwiw, one could only push the white/black list actions
to the item list in an SpamContextMenu's initComponents before calling
the parent, but for just two it really doesn't matters much anyway..
next prev parent reply other threads:[~2022-10-22 14:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 19:14 [pmg-devel] [PATCH pmg-gui 0/4] low-hanging improvments for the quarantine interface Stoiko Ivanov
2022-10-20 19:14 ` [pmg-devel] [PATCH pmg-gui 1/4] fix #4137: display receiver in attachment/virus quarantine Stoiko Ivanov
2022-10-22 14:30 ` [pmg-devel] applied: " Thomas Lamprecht
2022-10-20 19:14 ` [pmg-devel] [PATCH pmg-gui 2/4] quarantine: contextmenu: refactor for use in other quarantines Stoiko Ivanov
2022-10-22 14:32 ` Thomas Lamprecht [this message]
2022-10-20 19:14 ` [pmg-devel] [PATCH pmg-gui 3/4] quarantine: add common controller for all quarantines Stoiko Ivanov
2022-10-22 13:37 ` Thomas Lamprecht
2022-10-20 19:15 ` [pmg-devel] [PATCH pmg-gui 4/4] quarantine: move all quarantines to the new controller Stoiko Ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9e26ded-e131-44f4-b10d-e5116d2e8eff@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
--cc=s.ivanov@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal