all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH manager] acme: ui: handle missing meta field in directory response
@ 2024-04-22  9:01 Folke Gleumes
  2024-04-22  9:06 ` Stoiko Ivanov
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Folke Gleumes @ 2024-04-22  9:01 UTC (permalink / raw)
  To: pve-devel

When none of the meta fields is set by the directory, the whole
dictionary is missing from the response, leading to an exception
when testing for fields inside it.

Signed-off-by: Folke Gleumes <f.gleumes@proxmox.com>
---
 www/manager6/node/ACME.js | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/www/manager6/node/ACME.js b/www/manager6/node/ACME.js
index a0db51a6..7fe49171 100644
--- a/www/manager6/node/ACME.js
+++ b/www/manager6/node/ACME.js
@@ -150,15 +150,18 @@ Ext.define('PVE.node.ACMEAccountCreate', {
 				    directory: value,
 				},
 				success: function(response, opt) {
-				    if (response.result.data.termsOfService) {
+				    if (response.result.data && response.result.data.termsOfService) {
 					field.setValue(response.result.data.termsOfService);
 					disp.setValue(response.result.data.termsOfService);
 					checkbox.setHidden(false);
 				    } else {
-					checkbox.setValue(false);
+					// Needed to pass input verification and enable register button
+					// has no influence on the submitted form
+					checkbox.setValue(true);
 					disp.setValue("No terms of service agreement required");
 				    }
-				    vm.set('eabRequired', !!response.result.data.externalAccountRequired);
+				    vm.set('eabRequired', !!(response.result.data &&
+					response.result.data.externalAccountRequired));
 				},
 				failure: function(response, opt) {
 				    disp.setValue(undefined);
-- 
2.39.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-04-22 10:39 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-22  9:01 [pve-devel] [PATCH manager] acme: ui: handle missing meta field in directory response Folke Gleumes
2024-04-22  9:06 ` Stoiko Ivanov
2024-04-22  9:08 ` Folke Gleumes
2024-04-22 10:39 ` [pve-devel] applied: " Thomas Lamprecht

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal