all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Lukas Wagner <l.wagner@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>,
	Filip Schauer <f.schauer@proxmox.com>,
	Wolfgang Bumiller <w.bumiller@proxmox.com>
Subject: Re: [pbs-devel] [PATCH vma-to-pbs] Initial commit
Date: Fri, 29 Sep 2023 15:38:17 +0200	[thread overview]
Message-ID: <a9080dad-d097-4a2e-9b49-2b9b5df23129@proxmox.com> (raw)
In-Reply-To: <3bf667ac-ab0a-dc60-214e-a185052598bf@proxmox.com>



On 9/29/23 15:22, Filip Schauer wrote:
>>> --- /dev/null
>>> +++ b/.gitmodules
>>> @@ -0,0 +1,6 @@
>>> +[submodule "submodules/proxmox-backup-qemu"]
>>> +    path = submodules/proxmox-backup-qemu
>>> +    url = git://git.proxmox.com/git/proxmox-backup-qemu.git
>>> +[submodule "submodules/proxmox"]
>>> +    path = submodules/proxmox
>>> +    url = git://git.proxmox.com/git/proxmox.git
>> ^ We don't need proxmox.git as submodule.
> We use proxmox_sys::linux::tty::read_password.

I believe what Wolfgang meant was that you do not to need to add
proxmox.git as a submodule. Since you patch crate.io with the local
registry at /usr/share/cargo, you can just install the dependencies
that you need via apt and use them just as any other dep inside your
Cargo.toml file.

Since you need `proxmox-sys`, the required package would be
`librust-proxmox-sys-dev`. The newest packaged version is 0.5.0-1,
so you'd need to add

proxmox-sys = "0.5.0"

to your Cargo.toml file.


-- 
- Lukas




  reply	other threads:[~2023-09-29 13:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-22 12:41 Filip Schauer
2023-09-26 13:11 ` Wolfgang Bumiller
2023-09-29 13:22   ` Filip Schauer
2023-09-29 13:38     ` Lukas Wagner [this message]
2023-09-29 13:12 Filip Schauer
2023-09-29 13:15 ` Filip Schauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a9080dad-d097-4a2e-9b49-2b9b5df23129@proxmox.com \
    --to=l.wagner@proxmox.com \
    --cc=f.schauer@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    --cc=w.bumiller@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal